[vtk-developers] merge request for vtkCamera.cxx eyeseparation and near far planes correction (UNCLASSIFIED)

[David Cole]

OffAxis projection in VTK is woefully underdocumented, and accepting
this pull request will only add to the mystery.

I would suggest documenting that the coordinates used to specify it
are in vtkCamera coordinates (not world), and clarifying with comments
in the code what some of the constants used are for. Also,
EyeSeparation appears to be specified in meters, although it's unclear
how it relates to any of the VTK coordinate systems or to the size of
the actual display being used.


2 cents,
David C.


On Thu, Mar 17, 2016 at 4:17 PM, Aashish Chaudhary
<aashish.chaudhary at kitware.com> wrote:
> Hi Joe,
>
> Thank for you for the PR. Could you please describe the problem in bit more
> detail?
>
> Thanks,
>
>
> On Thu, Mar 17, 2016 at 4:04 PM, Hennessey, Joseph G CTR USARMY RDECOM ARL
> (US) <joseph.g.hennessey2.ctr at mail.mil> wrote:
>>
>> CLASSIFICATION: UNCLASSIFIED
>>
>> Hello,
>>
>> I have modified
>>
>> Rendering/Core/vtkCamera.cxx:: ComputeOffAxisProjectionFrustum
>>
>> To fix a problem with eyeseparation and near and far planes for use with
>> immersive paraview
>>
>> The merge request is called
>>
>> fix ComputeOffAxisProjectionFrustum eyeseparation and near and far planes.
>>
>>
>> https://gitlab.kitware.com/vtk/vtk/commit/4fe4fabb420bba77740ec988d060c5c296
>> d36afb
>>
>> Commit 4fe4fabb420bba77740ec988d060c5c296d36afb
>>
>> Authored by Joseph G. Hennessey about an hour ago
>> 1 parent d52198e1
>>
>> Please add this to VTK and indirectly to ParaView
>>
>> Thanks,
>>
>> Joe
>>
>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> Joseph G. Hennessey Ph.D., Lockheed Martin
>> Army Research Lab
>> DOD Supercomputing Resource Center
>>
>>
>> CLASSIFICATION: UNCLASSIFIED
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>
>>
>
>
>
> --
> | Aashish Chaudhary
> | Technical Leader
> | Kitware Inc.
> | http://www.kitware.com/company/team/chaudhary.html
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>