[vtk-developers] Add GetModifiedTime deprecate GetMTime

[Bill Lorensen]

Why not in vtkType.h
#if defined(WIN32)
typedef vtkTypeUInt64 vtkTypeMTime;
#else
typedef unsigned long vtkTypeMTime;
#endif

In vtkObject.h and other GetMTimes'
  virtual vtkTypeMTime GetMTime();

Windows apps will have to change their GetMTimes' in their VTK derived
subclasses.



On Thu, Aug 4, 2016 at 1:28 PM, Robert Maynard
<robert.maynard at kitware.com> wrote:
> I agree with David. I prefer correctness to full backwards
> compatibility, especially so with something like consistently having
> 64bit MTimes on all platforms.
>
> Personally I don't see the value in having the return type as a
> typedef compared to having the caller do a static cast ( which is what
> MTime would have to do internally ).
>
> On Thu, Aug 4, 2016 at 12:53 PM, David Cole via vtk-developers
> <vtk-developers at vtk.org> wrote:
>> Except.... I think fixing the overflow bug on Windows is more
>> important than full source compatibility. A default build (no need to
>> set anything in CMake) of the new version of VTK on Windows with this
>> capability should result in 64-bit MTime values and avoid the overflow
>> condition.
>>
>> I prefer correctness to full/100% backwards compatibility.
>>
>>
>>
>>
>> On Thu, Aug 4, 2016 at 11:27 AM, Sean McBride <sean at rogue-research.com> wrote:
>>> On Thu, 4 Aug 2016 10:32:23 -0400, David Cole via vtk-developers said:
>>>
>>>>A nice-to-the-user-who-needs-that capability would be to typedef a
>>>>type for the return value of GetMTime, and then allow for user
>>>>definition of that type. Default to uint64_t, but allow for user
>>>>definition.
>>>
>>> Was just going to suggest that.  It could be typedefed to exactly what it is today, giving full source compatibility; and then if you build with VTK_LEGACY_REMOVE (or similar) it could be typedefed to the new 64 bit type.
>>>
>>> Cheers,
>>>
>>> --
>>> ____________________________________________________________
>>> Sean McBride, B. Eng                 sean at rogue-research.com
>>> Rogue Research                        www.rogue-research.com
>>> Mac Software Developer              Montréal, Québec, Canada
>>>
>>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>



-- 
Unpaid intern in BillsBasement at noware dot com