[vtk-developers] vtkRenderingOpenGL2Cxx-TestDepthOfFieldPass ERRORs

[Andras Lasso]

The mechanism that I wrote about is useful for catching all errors/warnings logged by any class during any test. It can detect real errors that might otherwise go unnoticed.

Grabbing errors with observer works well for verifying that expected error events are invoked, but it will not detect unexpected errors. Parsing the test output with a regexp works for catching any unexpected errors, but it is difficult to manage when there are expected errors, too.

Andras

From: Bill Lorensen [mailto:bill.lorensen at gmail.com]
Sent: October 26, 2015 6:24 PM
To: Andras Lasso <lasso at queensu.ca>
Cc: VTK Developers <vtk-developers at vtk.org>
Subject: RE: [vtk-developers] vtkRenderingOpenGL2Cxx-TestDepthOfFieldPass ERRORs


These are real errors that need to be fixed. For those errors that are on purpose, we grab them with an error observer and verify that the proper error message is generated.
On Oct 26, 2015 4:29 PM, "Andras Lasso" <lasso at queensu.ca<mailto:lasso at queensu.ca>> wrote:
Hi Bill,

You might find this info useful: We do a similar check in (some) automated tests in Slicer, but instead of parsing the test output we check the number logged VTK error and warning messages. We also have some convenience macros for initialization and reporting and to manage expected errors and warnings. Checks can be added without modifying existing tests, just changing the test driver macros.

More details:
http://slicer.org/doc/html/classvtkTestingOutputWindow.html
http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/CxxTests
https://github.com/Slicer/Slicer/blob/master/Libs/vtkAddon/

It would be nice if the VTK core would have such a feature (similarly to how tests can be made to exit with failure when there are memory leaks).

Andras

-----Original Message-----
From: vtk-developers [mailto:vtk-developers-bounces at vtk.org<mailto:vtk-developers-bounces at vtk.org>] On Behalf Of Bill Lorensen
Sent: Monday, October 26, 2015 12:52 PM
To: VTK Developers <vtk-developers at vtk.org<mailto:vtk-developers at vtk.org>>
Subject: [vtk-developers] vtkRenderingOpenGL2Cxx-TestDepthOfFieldPass ERRORs

Folks,

I am working on a patch that will report test failures if "ERROR"
appeares in the test output.

The subject test will fail once I merge this patch (which is at least a week away). It reports

ERROR: In /Users/kitware/dashboards/buildbot/vtk-trey-osx-shared-release_opengl2_python_qt/source/Rendering/OpenGL2/vtkTextureUnitManager.cxx,
line 58
vtkTextureUnitManager (0x7f9432c9ab80): the texture unit is deleted but some texture units have not been released: Id=2

Bill
_______________________________________________
Powered by www.kitware.com<http://www.kitware.com>

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Search the list archives at: http://markmail.org/search/?q=vtk-developers

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/vtk-developers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20151027/17471786/attachment-0001.html>