<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">The mechanism that I wrote about is useful for catching all errors/warnings logged by any class during any test. It can detect real errors that might otherwise
go unnoticed.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Grabbing errors with observer works well for verifying that expected error events are invoked, but it will not detect unexpected errors. Parsing the test output
with a regexp works for catching any unexpected errors, but it is difficult to manage when there are expected errors, too.<o:p></o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Andras<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Bill Lorensen [mailto:bill.lorensen@gmail.com]
<br>
<b>Sent:</b> October 26, 2015 6:24 PM<br>
<b>To:</b> Andras Lasso <lasso@queensu.ca><br>
<b>Cc:</b> VTK Developers <vtk-developers@vtk.org><br>
<b>Subject:</b> RE: [vtk-developers] vtkRenderingOpenGL2Cxx-TestDepthOfFieldPass ERRORs<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p>These are real errors that need to be fixed. For those errors that are on purpose, we grab them with an error observer and verify that the proper error message is generated.<o:p></o:p></p>
<div>
<p class="MsoNormal">On Oct 26, 2015 4:29 PM, "Andras Lasso" <<a href="mailto:lasso@queensu.ca">lasso@queensu.ca</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi Bill,<br>
<br>
You might find this info useful: We do a similar check in (some) automated tests in Slicer, but instead of parsing the test output we check the number logged VTK error and warning messages. We also have some convenience macros for initialization and reporting
and to manage expected errors and warnings. Checks can be added without modifying existing tests, just changing the test driver macros.<br>
<br>
More details:<br>
<a href="http://slicer.org/doc/html/classvtkTestingOutputWindow.html" target="_blank">http://slicer.org/doc/html/classvtkTestingOutputWindow.html</a><br>
<a href="http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/CxxTests" target="_blank">http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/Tutorials/CxxTests</a><br>
<a href="https://github.com/Slicer/Slicer/blob/master/Libs/vtkAddon/" target="_blank">https://github.com/Slicer/Slicer/blob/master/Libs/vtkAddon/</a><br>
<br>
It would be nice if the VTK core would have such a feature (similarly to how tests can be made to exit with failure when there are memory leaks).<br>
<br>
Andras<br>
<br>
-----Original Message-----<br>
From: vtk-developers [mailto:<a href="mailto:vtk-developers-bounces@vtk.org">vtk-developers-bounces@vtk.org</a>] On Behalf Of Bill Lorensen<br>
Sent: Monday, October 26, 2015 12:52 PM<br>
To: VTK Developers <<a href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</a>><br>
Subject: [vtk-developers] vtkRenderingOpenGL2Cxx-TestDepthOfFieldPass ERRORs<br>
<br>
Folks,<br>
<br>
I am working on a patch that will report test failures if "ERROR"<br>
appeares in the test output.<br>
<br>
The subject test will fail once I merge this patch (which is at least a week away). It reports<br>
<br>
ERROR: In /Users/kitware/dashboards/buildbot/vtk-trey-osx-shared-release_opengl2_python_qt/source/Rendering/OpenGL2/vtkTextureUnitManager.cxx,<br>
line 58<br>
vtkTextureUnitManager (0x7f9432c9ab80): the texture unit is deleted but some texture units have not been released: Id=2<br>
<br>
Bill<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">
http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" target="_blank">
http://markmail.org/search/?q=vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" target="_blank">http://public.kitware.com/mailman/listinfo/vtk-developers</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</body>
</html>