[vtk-developers] vtkDepthSortPolyData modernization

Berk Geveci berk.geveci at kitware.com
Thu Dec 3 14:56:37 EST 2015


Will's reviewing it.

On Thu, Dec 3, 2015 at 10:36 AM, Burlen Loring <burlen.loring at gmail.com>
wrote:

> Hi Berk,
>
> Just checking in. I'm sure it's one of those things that could get lost in
> the shuffle.
>
> Burlen
>
>
> On 11/12/2015 10:09 AM, Burlen Loring wrote:
>
> Hi Berk,
>
> Thanks & have a good trip.
>
> Burlen
>
> On 11/12/2015 09:43 AM, Berk Geveci wrote:
>
> Hi Burlen,
>
> We are quite swamped by SC preparations this week. I'll be happy to take a
> look after SC.
>
> Best,
> -berk
>
> On Wed, Nov 11, 2015 at 12:04 PM, Burlen Loring <burlen.loring at gmail.com>
> wrote:
>
>> Hi All,
>>
>> Would anyone be willing to review this patch?
>> https://gitlab.kitware.com/vtk/vtk/merge_requests/844
>>
>> I was profiling VisIt and noticed that vtkDepthSortPolyData (in spite of
>> its limitations it is used by VisIt for transparent rendering) made use of
>> qsort and about 1/2 the time was spent by qsort. std::sort is known to be
>> faster because of the possibility of the compiler to inline the
>> comparisons. Updating qsort to std::sort seemed like an easy way to make it
>> faster. As I worked the profiler pointed out a number of other fairly easy
>> things to improve and overall the class is now ~3x faster for two of the
>> modes and ~2x faster for the other. I enumerated the changes in the commit
>> message and have added a cxx test to improve the test coverage.
>>
>> If you have the time, please take a look, and let me know if you have any
>> feedback on it.
>>
>> Thanks
>> Burlen
>>
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> <http://www.kitware.com/opensource/opensource.html>
>> http://www.kitware.com/opensource/opensource.html
>>
>> Search the list archives at: http://markmail.org/search/?q=vtk-developers
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20151203/482eb16e/attachment.html>


More information about the vtk-developers mailing list