<div dir="ltr">Will's reviewing it.</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Dec 3, 2015 at 10:36 AM, Burlen Loring <span dir="ltr"><<a href="mailto:burlen.loring@gmail.com" target="_blank">burlen.loring@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Hi Berk,<br>
<br>
Just checking in. I'm sure it's one of those things that could get
lost in the shuffle.<span class="HOEnZb"><font color="#888888"><br>
<br>
Burlen</font></span><div><div class="h5"><br>
<br>
<div>On 11/12/2015 10:09 AM, Burlen Loring
wrote:<br>
</div>
<blockquote type="cite">
Hi Berk, <br>
<br>
Thanks & have a good trip.<br>
<br>
Burlen<br>
<br>
<div>On 11/12/2015 09:43 AM, Berk Geveci
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi Burlen,
<div><br>
</div>
<div>We are quite swamped by SC preparations this week. I'll
be happy to take a look after SC.</div>
<div><br>
</div>
<div>Best,</div>
<div>-berk</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Wed, Nov 11, 2015 at 12:04 PM,
Burlen Loring <span dir="ltr"><<a href="mailto:burlen.loring@gmail.com" target="_blank">burlen.loring@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi All,<br>
<br>
Would anyone be willing to review this patch?<br>
<a href="https://gitlab.kitware.com/vtk/vtk/merge_requests/844" rel="noreferrer" target="_blank">https://gitlab.kitware.com/vtk/vtk/merge_requests/844</a><br>
<br>
I was profiling VisIt and noticed that
vtkDepthSortPolyData (in spite of its limitations it is
used by VisIt for transparent rendering) made use of qsort
and about 1/2 the time was spent by qsort. std::sort is
known to be faster because of the possibility of the
compiler to inline the comparisons. Updating qsort to
std::sort seemed like an easy way to make it faster. As I
worked the profiler pointed out a number of other fairly
easy things to improve and overall the class is now ~3x
faster for two of the modes and ~2x faster for the other.
I enumerated the changes in the commit message and have
added a cxx test to improve the test coverage.<br>
<br>
If you have the time, please take a look, and let me know
if you have any feedback on it.<br>
<br>
Thanks<br>
Burlen<br>
<br>
<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank"></a><a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Search the list archives at: <a href="http://markmail.org/search/?q=vtk-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=vtk-developers</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/vtk-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/vtk-developers</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>