[vtk-developers] Approving a gitlab topic
Ben Boeckel
ben.boeckel at kitware.com
Fri Apr 17 08:56:30 EDT 2015
On Wed, Apr 15, 2015 at 22:20:04 -0400, David Cole via vtk-developers wrote:
> Buttons, labelled "Approve" and "Reject"
>
> Not to be overly pedantic, but buttons should indicate the action you
> are doing by clicking them, not the action you did once they have been
> clicked. (i.e. -- make it an action verb, not a past tense "did that"
> thing...)
>
> +2 for buttons!
Here are some bookmarklets you can add to your browser add put in the
bookmark toolbar:
Ack:
javascript:(function(){jQuery("textarea.note_text:visible").val("+1")})()
Review:
javascript:(function(){jQuery("textarea.note_text:visible").val("+2")})()
Tested:
javascript:(function(){jQuery("textarea.note_text:visible").val("+3")})()
Reject:
javascript:(function(){jQuery("textarea.note_text:visible").val("-1")})()
Buildbot:
javascript:(function(){jQuery("textarea.note_text:visible").val("@buildbot test")})()
Merge:
javascript:(function(){jQuery("textarea.note_text:visible").val("\n\nDo: merge")})()
Note that these will *overwrite* any text currently in the comment box.
--Ben
More information about the vtk-developers
mailing list