[vtk-developers] Approving a gitlab topic

[Berk Geveci]

I %100 agree with Brad.

-berk

On Thu, Apr 16, 2015 at 10:47 AM, Brad King <brad.king at kitware.com> wrote:

> On 04/15/2015 10:20 PM, David Cole via vtk-developers wrote:
> > Buttons, labelled "Approve" and "Reject"
> >
> > Not to be overly pedantic, but buttons should indicate the action you
> > are doing by clicking them, not the action you did once they have been
> > clicked. (i.e. -- make it an action verb, not a past tense "did that"
> > thing...)
> >
> > +2 for buttons!
>
> Adding buttons will require modification to GitLab, which we've
> ruled must be kept to a minimum.  We already have a few mods in
> use to get the event web hooks we need.  Only after we've gotten
> those upstreamed successfully should we consider further mods
> locally.  We don't want to end up forked like we did with Gerrit.
>
> -Brad
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20150416/27f7925c/attachment.html>