[vtk-developers] Approving a gitlab topic

Sean McBride sean at rogue-research.com
Wed Apr 15 16:15:12 EDT 2015


Even that is hard to remember (though better).  Would it not be possible to put buttons with names like "Approved" and "Approved & Tested".  Then one has nothing to remember.

Sean



On Wed, 15 Apr 2015 15:48:43 -0400, Robert Maynard said:

>Hi Bill,
>
>I was discussing this with other developers a few days ago and
>mentioned that the Acked-by/etc are hard to remember and proposed that
>we allow +1 to mean approved by a developer, and +2 to mean approved
>and tested.
>
>On Wed, Apr 15, 2015 at 3:27 PM, Bill Lorensen <bill.lorensen at gmail.com>
>wrote:
>> To approve a gitlab topic I do?
>>
>> Acked-by: me
>>
>> Why not?
>>
>> Approved-by: me
>>
>> The latter seems more descriptive.
>>
>>  I currently contribute to 3 open source projects, vtk(gitlab),
>> itk(gerrit) and slicer(github). They each have their own workflow. I
>> also have several of my own projects that uses github. I contribute to
>> these projects in spurts.




More information about the vtk-developers mailing list