[vtk-developers] Driving away your existing developers

[Matt McCormick]

Here is a script [1] for reference I wrote a while ago (have not used
recently), that will select potential reviewers and add them to a
Gerrit patch via the command line.  It uses recent changes (within the
last five years) and sorts by the number of lines changed to select
reviewers. It is amazing how many people tweak and improve a file over
its lifetime, especially for a project like VTK.

HTH,
Matt

[1] https://gist.github.com/thewtex/674093


On Wed, Sep 3, 2014 at 10:35 AM, David E DeMarle
<dave.demarle at kitware.com> wrote:
> The idea of having gerrit automatically add reviewers is a small tweak that
> will improve things greatly.
>
> Can we have a simple gerrit side hook that adds the previous 3 authors of
> all touched files?
>
>
> David E DeMarle
> Kitware, Inc.
> R&D Engineer
> 21 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-881-4909
>
>
> On Wed, Sep 3, 2014 at 10:33 AM, David E DeMarle <dave.demarle at kitware.com>
> wrote:
>>
>> One thing we can hope to do better next time to not alienate the old
>> timers (including myself).
>>
>> * The transition from CVS to today's gerrit workflow was necessarily long,
>> but there were frequent adjustments along the way as we learned and built up
>> the infrastructure. Every change in the process meant retraining all of the
>> (self interested and busy) contributors.
>>
>> Whatever our end goal is with the new infrastructure - we need to work
>> harder to minimize the number of changes to the commit process, to keep the
>> contribution process as dead simple as it can be, and to describe the
>> mechanics clearly and loudly.
>>
>>
>> David E DeMarle
>> Kitware, Inc.
>> R&D Engineer
>> 21 Corporate Drive
>> Clifton Park, NY 12065-8662
>> Phone: 518-881-4909
>>
>>
>> On Tue, Sep 2, 2014 at 9:38 AM, Brad King <brad.king at kitware.com> wrote:
>>>
>>> On 08/28/2014 11:07 AM, Sean McBride wrote:
>>> > 1) a 'commits' email list, like other projects.  Where you get an
>>> > email for every merge into master.
>>>
>>> We've had one of these since CVS days:
>>>
>>>  http://www.vtk.org/mailman/listinfo/vtk-commit
>>>
>>> It still works.
>>>
>>> -Brad
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://public.kitware.com/mailman/listinfo/vtk-developers
>>>
>>
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://public.kitware.com/mailman/listinfo/vtk-developers
>
>