[vtk-developers] VTK code review / testing / integration workflow
Ben Boeckel
ben.boeckel at kitware.com
Mon Aug 25 08:51:55 EDT 2014
On Sat, Aug 23, 2014 at 19:58:53 -0400, Berk Geveci wrote:
> I will follow up with a few initial workflow suggestions. Please send your
> workflow suggestions or requirements.
What about the ability to handle "in-progress" branch reviews more
gracefully? Currently, there are a couple of things in Gerrit which
greatly hinder this:
- Gerrit hurks something awful when a commit shows up in two branches
(unified-bindings had a branch split off from it and some commits
abandoned and/or merged…which broke unified-bindings' review and is
presently unviewable in Gerrit at all[1] and cannot be closed or
abandoned);
- Gerrit is awful at branch dependencies (mainly due to the lack of
the concept and attempts being thwarted by the above issue);
- Comments are per patch set and not carried over if the commented-on
code didn't change which makes fixing half the comments on a review
a pain.
--Ben
[1]http://review.source.kitware.com/#/t/3199/
More information about the vtk-developers
mailing list