[vtk-developers] vtkCirclePackFrontChainLayoutStrategy.cxx weird indentation (-Windent)

[Sean McBride]

On Thu, 3 Apr 2014 12:19:58 -0400, Ben Boeckel said:

>> > Anyone know vtkCirclePackFrontChainLayoutStrategy.cxx?
>> >
>> > git blame suggests Thomas Otahal & Marcus Hanwell.
>> >
>> I don't remember writing this, but I may have done some editing/clean
>> up. I can go through history a little more if no one steps up who
>> remembers more.
>
>Passing -MM -CC -w to git shows Marcus' changes are from "Removed the
>use of vtkstd". This hunk seems to indicate it is bad indentation:
>
>@@ -458,11 +484,9 @@ bool vtkCirclePa
>ckFrontChainLayoutStrategyImplementation::validCjAfterCn(vtkIdTy
>   while(CnSearchPathLength < searchPathLength)
>     {
>     CnSearchPathLength++;
>-    --Cn;
>+    decrListIteratorWrapAround(Cn, frontChain);
>     if(Cn == frontChain.end())
>-      {
>-      --Cn;
>-      }
>+      decrListIteratorWrapAround(Cn, frontChain);
>       if(this->circlesIntersect(Ci,
>                                 *Cn,
>                                 circlesArray))
>
>See commit 2af896a39a73d56958f48d558103c547308c091c.

Well, the suspect indentation of "if(this->circlesIntersect" didn't change in that commit, but I guess since it was previously explicitly outside the braces that the indentation is indeed wrong.

For review:
<http://review.source.kitware.com/15211>

Cheers,

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada