[vtk-developers] vtkCirclePackFrontChainLayoutStrategy.cxx weird indentation (-Windent)
Ben Boeckel
ben.boeckel at kitware.com
Thu Apr 3 12:19:58 EDT 2014
On Thu, Apr 03, 2014 at 11:34:45 -0400, Marcus D. Hanwell wrote:
> On Thu, Apr 3, 2014 at 11:04 AM, Sean McBride <sean at rogue-research.com> wrote:
> > Anyone know vtkCirclePackFrontChainLayoutStrategy.cxx?
> >
> > git blame suggests Thomas Otahal & Marcus Hanwell.
> >
> I don't remember writing this, but I may have done some editing/clean
> up. I can go through history a little more if no one steps up who
> remembers more.
Passing -MM -CC -w to git shows Marcus' changes are from "Removed the
use of vtkstd". This hunk seems to indicate it is bad indentation:
@@ -458,11 +484,9 @@ bool vtkCirclePackFrontChainLayoutStrategyImplementation::validCjAfterCn(vtkIdTy
while(CnSearchPathLength < searchPathLength)
{
CnSearchPathLength++;
- --Cn;
+ decrListIteratorWrapAround(Cn, frontChain);
if(Cn == frontChain.end())
- {
- --Cn;
- }
+ decrListIteratorWrapAround(Cn, frontChain);
if(this->circlesIntersect(Ci,
*Cn,
circlesArray))
See commit 2af896a39a73d56958f48d558103c547308c091c. And this is why always
using braces is a good thing :) .
--Ben
More information about the vtk-developers
mailing list