[vtk-developers] vtkCirclePackFrontChainLayoutStrategy.cxx weird indentation (-Windent)

[Sean McBride]

Hi all,

Anyone know vtkCirclePackFrontChainLayoutStrategy.cxx?

git blame suggests Thomas Otahal & Marcus Hanwell.

I've been trying an experimental clang warning -Windent[1] that warns on weird indentation, and it found a nice one:

  while(CnSearchPathLength < searchPathLength)
    {
    CnSearchPathLength++;
    decrListIteratorWrapAround(Cn, frontChain);
    if(Cn == frontChain.end())
      decrListIteratorWrapAround(Cn, frontChain);
      if(this->circlesIntersect(Ci,
                                *Cn,
                                circlesArray))
        {
        return false;
        }
    }

Is the inner 'if' indented too much, or are braces missing for the outer 'if'?

[1] <http://llvm.org/bugs/show_bug.cgi?id=18938>

Cheers,

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada