[vtk-developers] TestBunykRayCastFunction failure; invalid double > uint8 cast

Sean McBride sean at rogue-research.com
Fri Mar 22 17:00:36 EDT 2013


On Fri, 22 Mar 2013 14:38:17 -0600, David Gobbi said:

>Yeah, pretty much what Will says.  Each loop increments a bit too much.
>I suspect that the code has an off-by-one error right at line 242:
>
>        = (this->IntegrationTableScalarResolution-2)/(range[1]-range[0]);
>
>This would make more sense if it was "-1" instead of "-2".  There is a
>similarly suspicious "-2" at line 183.

Well that fixes the bad cast, and my logging now goes from 0 to 255 exactly every time.  The test now passes, and no other failures are introduced.  So:

<http://review.source.kitware.com/#/c/10399/>

I'll trust in you guys to review...

Cheers,

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada





More information about the vtk-developers mailing list