[vtk-developers] TestStackedPlot failures

Marcus D. Hanwell marcus.hanwell at kitware.com
Thu Mar 7 15:43:33 EST 2013


On Thu, Mar 7, 2013 at 1:51 PM, Marcus D. Hanwell
<marcus.hanwell at kitware.com> wrote:
> On Thu, Mar 7, 2013 at 8:10 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> Marcus,
>>
>> The Cxx test was changed but the Python test was not.
>>
> Yeah, sorry I missed that (and I guess we didn't spot it in the
> review). I approved and merged your topic earlier today.
>
For posterity...we missed this because the Python test uses the same
baseline image as the C++ test. When I pushed the topic the C++ test
failed as expected (and we could see the new baseline), but the Python
test continued to pass (as it matched the old baseline). I pushed in
the new baseline, Chris merged the topic and then the Python test we
hadn't spotted began to fail. Bill changed its code to match the C++
test and all is well.

I don't think this will happen much, and despite the timing I really
didn't do it on purpose to demonstrate a point ;-) Merging
master/rebasing etc wouldn't have helped here.

Marcus



More information about the vtk-developers mailing list