[vtk-developers] [VTK 0014170]: Segfault in vtkSmartVolumeMapper

[Bill Lorensen]

Ooops. John I merged your topic without notifying you.

My bad,

Bill



On Thu, Jul 18, 2013 at 10:45 AM, David E DeMarle
<dave.demarle at kitware.com>wrote:

> And you make a good point John, it is best if people in the core do *not*merge each other's changes (only their own
> *after review*) and alert the external contributor when they do merge
> external changes. That way the person who wrote the code knows *when*they need to pay extra attention to the continuous and nightly results.
>
> David E DeMarle
> Kitware, Inc.
> R&D Engineer
> 21 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-881-4909
>
>
> On Thu, Jul 18, 2013 at 10:40 AM, David E DeMarle <
> dave.demarle at kitware.com> wrote:
>
>> Here is how it should work:
>>
>> Anyone in the core:
>> http://review.source.kitware.com/#/admin/groups/11,members has a build
>> and ctest spawned on mac, linux and windows immediately once they git
>> gerrit-push.
>>
>> Anyone gets test spawned only when someone in the core requests the tests
>> to run (for security)
>>
>> In either case click on the topic in gerrit and click on the filtered
>> CDash results to get to them.
>>
>> Anyone in the core can then merge the change (assuming the reviewers were
>> not grumpy) into master through gerrit. After this it is just like in the
>> old days, the continuous testers immediately test it a bit more thoroughly,
>> and then at 9pm the nightlies test it even more thoroughly.
>>
>>
>> David E DeMarle
>> Kitware, Inc.
>> R&D Engineer
>> 21 Corporate Drive
>> Clifton Park, NY 12065-8662
>> Phone: 518-881-4909
>>
>>
>> On Wed, Jul 17, 2013 at 4:10 AM, Biddiscombe, John A. <biddisco at cscs.ch>wrote:
>>
>>>  Not very impressed with this gerrit stuff. In the old days I’d commit
>>> a change and the next morning the dashboard would show the files updated
>>> and the tests run (this code wasn’t tested, so I’m not expecting problems).
>>> ****
>>>
>>> ** **
>>>
>>> How will I know when to monitor the dashboard when the commits sit
>>> inside gerrit until one day something presumably happens?****
>>>
>>> ** **
>>>
>>> JB****
>>>
>>> ** **
>>>
>>> *From:* Biddiscombe, John A.
>>> *Sent:* 15 July 2013 17:17
>>> *To:* Biddiscombe, John A.; David Cole; Bill Lorensen
>>> *Cc:* vtk-developers at vtk.org
>>> *Subject:* RE: [vtk-developers] [VTK 0014170]: Segfault in
>>> vtkSmartVolumeMapper****
>>>
>>> ** **
>>>
>>> On another machine the change-ID is generated correctly. So I’ve pushed
>>> from there.****
>>>
>>> ** **
>>>
>>> ** **
>>>
>>> ** **
>>>
>>> *From:* vtk-developers-bounces at vtk.org [
>>> mailto:vtk-developers-bounces at vtk.org <vtk-developers-bounces at vtk.org>]
>>> *On Behalf Of *Biddiscombe, John A.
>>> *Sent:* 15 July 2013 16:03
>>> *To:* David Cole; Bill Lorensen
>>> *Cc:* vtk-developers at vtk.org
>>> *Subject:* Re: [vtk-developers] [VTK 0014170]: Segfault in
>>> vtkSmartVolumeMapper****
>>>
>>> ** **
>>>
>>> I did the setup stuff first and tried many times to redo the commit, but
>>> it won’t generate one. Unfortunalty, I’m trying to work on another branch
>>> and if I switch back to the topic branch the entire paraview will rebuild
>>> again L so I’m reluctant to experiment.****
>>>
>>> ** **
>>>
>>> JB****
>>>
>>> ** **
>>>
>>> ** **
>>>
>>> *From:* David Cole [mailto:dlrdave at aol.com <dlrdave at aol.com>]
>>> *Sent:* 15 July 2013 16:00
>>> *To:* Bill Lorensen; Biddiscombe, John A.
>>> *Cc:* vtk-developers at vtk.org
>>> *Subject:* Re: [vtk-developers] [VTK 0014170]: Segfault in
>>> vtkSmartVolumeMapper****
>>>
>>> ** **
>>>
>>> > I can’t do a gerrit push because it keeps asking for an Id and I don’t
>>> want to make one up!****
>>>
>>> > ****
>>>
>>> > Where do I get it from?****
>>>
>>>  ****
>>>
>>>  ****
>>>
>>> It comes from the stuff set up by the setup for development script.****
>>>
>>>  ****
>>>
>>> If you made the commit before running the script, it won’t have one.****
>>>
>>>  ****
>>>
>>> If you just do “git commit --amend” now on that commit, one should be
>>> added for you.****
>>>
>>>  ****
>>>
>>> Then you should be able to push.****
>>>
>>>  ****
>>>
>>>  ****
>>>
>>> HTH,****
>>>
>>> David C.****
>>>
>>>  ****
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>
>>>
>>>
>>
>


-- 
Unpaid intern in BillsBasement at noware dot com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130718/bec4faf5/attachment.html>