[vtk-developers] vtkHyperOctree Deep Copy

[Trevor Irons]

Thanks. Two quick points

a) I will happily adopt a more flexible Octree class. That is great.

b) In the mean time, I would really like to get some kind of true deep copy
pushed into VTK for the HyperOctree Class. I certainly consider this a bug.
I realize parts of my patch are a little kludgy (mainly the static_cast)
but the vtkHyperOctree class already had a fair bit of this, so I was
pretty consistent with the existing codebase. I'm terrified of having to
maintain my branch during such a dynamic development phase in VTK. My
application relies on making deep copies of these objects.

Thanks so much.

-- Trevor


On 25 January 2013 14:29, Philippe Pébay <philippe.pebay at kitware.com> wrote:

> Hello Trevor,
>
> Yes indeed, because I have not yet written a replacement for this class. I
> need to look into it. In the meantime I am attaching a paper which we wrote
> for the 21st International Meshing Roundtable and that explains several
> aspects of the hyper tree grid.
>
> Best,
> Philippe
>
>
> On Thu, Jan 24, 2013 at 5:22 PM, Trevor Irons <trevorirons at gmail.com>wrote:
>
>> Thanks Philippe. I was unaware of the vtkHyperTreeGrid class. I am
>> currently making use of the vtkHyperOctreeSampleFunction<http://www.vtk.org/doc/nightly/html/classvtkHyperOctreeSampleFunction.html>method right now, which would seem to preclude me from migrating to your
>> newer class for the time being. Is this accurate?
>>
>>
>> -- Trevor
>>
>>
>> On 24 January 2013 08:50, Philippe Pébay <philippe.pebay at kitware.com>wrote:
>>
>>> Hello Trevor,
>>>
>>> Thank you for your message. I am currently working on vtkHyperTreeGrid
>>> data set, which generalizes the concepts contained in vtkHyperOctree. At
>>> some point the latter will be deprecated, and its functionality be
>>> completely assumed by the former. I will look at your patch and see if I
>>> can push it into the vtkHyperOctree in the meantime.
>>>
>>> Thank you
>>> Philippe
>>>
>>> On Thu, Jan 24, 2013 at 4:19 PM, Trevor Irons <trevorirons at gmail.com>wrote:
>>>
>>>> A little while ago I posted to the users list a problem with the
>>>> vtkHyperOctree->DeepCopy method:
>>>> http://www.vtk.org/pipermail/vtkusers/2013-January/127166.html
>>>>
>>>>
>>>> The problem is that the DeepCopy actually provides a shallow copy of
>>>> the underlying Octree.
>>>>
>>>> I have prepared a proposed patch that fixes this issue:
>>>> http://review.source.kitware.com/#/c/9452/
>>>>
>>>> And also filed a bug report:
>>>> http://vtk.org/Bug/view.php?id=13819
>>>>
>>>> This is my first time contributing to VTK. So I apologize if I have
>>>> done something wrong. Please consider merging this changeset, or something
>>>> similar. Is there another step I need to take to have the changeset
>>>> reviewed?
>>>>
>>>> Thanks,
>>>>
>>>> -- Trevor
>>>>
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> Philippe Pébay, PhD
>>> Director of Visualization and High Performance Computing /
>>> Directeur de la Visualisation et du Calcul Haute Performance
>>> Kitware SAS
>>> 26 rue Louis Guérin, 69100 Villeurbanne, France
>>> +33 (0) 6.83.61.55.70 / 4.37.45.04.15
>>> http://www.kitware.fr <http://www.kitware.fr/>
>>
>>
>>
>
>
> --
> Philippe Pébay, PhD
> Director of Visualization and High Performance Computing /
> Directeur de la Visualisation et du Calcul Haute Performance
> Kitware SAS
> 26 rue Louis Guérin, 69100 Villeurbanne, France
> +33 (0) 6.83.61.55.70 / 4.37.45.04.15
> http://www.kitware.fr <http://www.kitware.fr/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130125/08034e46/attachment.html>