[vtk-developers] Gerrit questions

[Bill Lorensen]

Sounds great.

Those strange image failures you experienced yesterday helped us find a
nasty problem in VTKData/Baselines

Bill

On Thu, Feb 28, 2013 at 12:19 PM, David Thompson <david.thompson at kitware.com
> wrote:

> Hi Bill,
>
> > Can you rebase you patch to master and push it again.
>
> Sure.
>
> > Also, I have some comments regarding your new images. The scalar bar do
> not "look as nice" as the original ones.
>
> I've added some padding back between the title and scalar bar. I want to
> test it a little more but will push this weekend sometime. And I appreciate
> the feedback.
>
>         Thanks,
>         David
>
> >
> >
> > On Thu, Feb 28, 2013 at 11:14 AM, David Thompson <
> david.thompson at kitware.com> wrote:
> > Hi David,
> >
> > > This has also been seen elsewhere. We have noticed a discrepancy in
> baseline alternates that may explain size differences like those reported
> here. ... We’ll trigger a new CDash at home builds later after that happens
> and we can check to see what those results look like.
> > >
> > > So, hold off on merging this for now. If nobody replies again before
> midnight tonight -- ping again to check on the status.
> >
> > Ping!
> >
> >         David
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
> >
> > Follow this link to subscribe/unsubscribe:
> > http://www.vtk.org/mailman/listinfo/vtk-developers
> >
> >
> >
> >
> > --
> > Unpaid intern in BillsBasement at noware dot com
>
> David Thompson
> R&D Engineer – Kitware, Inc.
> david.thompson at kitware.com
> (919)869-8868
> Suite G-4
> 101 E. Weaver St.
> Carrboro, NC 27510
>
>


-- 
Unpaid intern in BillsBasement at noware dot com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130228/1a36be10/attachment.html>