[vtk-developers] Gerrit request build

[David Cole]

We also need to start enforcing a rule that you CANNOT approve with only one reviewer unless the Gerrit CDash at home builds are totally green.

Does anybody object to starting that immediately, now that we are getting closer to green eveywhere?

Obviously, there will be exceptional cases, but 99% of the gerrit topics should be totally green before merging. One of the exceptions I can think of right away is to fix an important dashboard error elsewhere that has not shown up on the CDash at home builds. In such a case, I would still think it wise to wait for green gerrit builds, but at a minimum, there should be multiple people who build and test it themselves.


D


 

 

 

-----Original Message-----
From: Bill Lorensen <bill.lorensen at gmail.com>
To: Marcus D. Hanwell <marcus.hanwell at kitware.com>
Cc: VTK Developers <vtk-developers at vtk.org>
Sent: Wed, Feb 13, 2013 11:49 am
Subject: [vtk-developers] Gerrit request build


Marcus,

I notice that "request build" works at the change level, but not the
topic level.

As we get more outside contributors, we insiders need to make sure a
topic compiles and passes tests before we approve and submit a topic.

Just today, an external contributors topic was approved and merged
without a gerrit build. Turns out there was a syntax error.

Bill
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers


 ===
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130213/dd783047/attachment.html>