[vtk-developers] Python TestTemplates.py failing

David Cole dlrdave at aol.com
Mon Feb 4 15:20:59 EST 2013


Just by saying it here, as a socially enforced convention, and getting all reviewers to agree that we can't accept topics anymore until the CDash at home dashboards are green.

That also helps to kick start the reviewers into waiting for and looking at the results of the CDash at home builds, too.

 

 

 

-----Original Message-----
From: Bill Lorensen <bill.lorensen at gmail.com>
To: David Cole <dlrdave at aol.com>
Cc: david.gobbi <david.gobbi at gmail.com>; vtk-developers <vtk-developers at vtk.org>
Sent: Mon, Feb 4, 2013 3:12 pm
Subject: Re: [vtk-developers] Python TestTemplates.py failing


I don't know how to do that.

On Mon, Feb 4, 2013 at 3:09 PM, David Cole <dlrdave at aol.com> wrote:
> I would suggest excluding the remaining failing tests *just* from the gerrit
> builds until the tests are fixed.
>
> An even more effective way to get them fixed quickly would be to refuse
> approving any topics until all the gerrit tests are passing.
>
> We don't have to live with this.
>
>
> A non-green gerrit CDash build should be an automatic rejection.
>
>
>
> -----Original Message-----
> From: Bill Lorensen <bill.lorensen at gmail.com>
> To: David Gobbi <david.gobbi at gmail.com>
> Cc: VTK Developers <vtk-developers at vtk.org>
> Sent: Mon, Feb 4, 2013 3:01 pm
> Subject: Re: [vtk-developers] Python TestTemplates.py failing
>
> I'm concerned that gerrit reviewers are missing new failing tests
> because of recurrent failing tests. It is important to get the gerrit
> factory build failures to 0.
>
> Already this weekend, someone committed a patch that introduced a new
> recurring failure.
>
> It has been failing since mid-October.
>
> Bill
>
> On Mon, Feb 4, 2013 at 2:46 PM, David Gobbi <david.gobbi at gmail.com> wrote:
>> On Mon, Feb 4, 2013 at 12:26 PM, Bill Lorensen <bill.lorensen at gmail.com
>>
> wrote:
>>>
>>> Should we suppress this until you can get to it? It is one of two
>>> tests failing on the gerrit ubuntu build.
>>
>> No, I don't consider that to be sufficient reason to suppress it.
>> It's a valid failure, not caused by hardware- or platform-specific
>> issues.  It should not be suppressed just to make the dashboard
>> green.  I'll find a few hours this week to work on it.
>>
>>  - David
>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>



-- 
Unpaid intern in BillsBasement at noware dot com

 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130204/5b5d2ef0/attachment.html>


More information about the vtk-developers mailing list