[vtk-developers] vtkSESAMEReader status

[Bill Lorensen]

Utkarsh,

There is already vtkPrismSESAMEReader in the Paraview plugins. The VTK
version, called vtkSESAMEReader does not work andI propose that we
remove it from VTK. I have a gerrit patch here:
http://review.source.kitware.com/#/t/3760/


On Sun, Dec 22, 2013 at 11:15 AM, Utkarsh Ayachit
<utkarsh.ayachit at kitware.com> wrote:
> BIll,
>
> Those should be moved to ParaView (after having verified that they are
> used at all by ParaView still). I'll put that on my plate.
>
> Utkarsh
>
> On Sat, Dec 21, 2013 at 1:16 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> Folks,
>>
>> During my initial scan of under covered classes, I started to look at readers.
>>
>> SESAMEReader has no test and no data. I did find some sesame data in
>> the paraview data git repo. A wrote a small program to read a sesame
>> file and display the resultant rectilinear grid. the vtkSESAMEReader
>> fails with this error:
>>
>> ERROR: In /Users/lorensen/ProjectsGIT/VTK/Common/ExecutionModel/vtkExecutive.cxx,
>> line 754
>> vtkCompositeDataPipeline (0x7fc312002af0): Algorithm
>> vtkSESAMEReader(0x7fc3120022a0) returned failure for request:
>> vtkInformation (0x7fc31060da20)
>>   Debug: Off
>>   Modified Time: 1244
>>   Reference Count: 1
>>   Registered Events: (none)
>>   Request: REQUEST_DATA
>>   ALGORITHM_AFTER_FORWARD: 1
>>   FORWARD_DIRECTION: 0
>>   FROM_OUTPUT_PORT: 0
>>
>> Then, I discovered vtkPrismSESAMEReader in the paraview repo. Just for
>> chuckles, I moved it into VTK/IO/Geometry and changed my program to
>> use it.
>>
>> It seemed to work!!!
>>
>> Question: Should we remove vtkSESAMEReader from VTK? It does not work
>> and is not tested.
>>
>> Or, should we move the vtkPrimsmSESAMEReader into vtk, renaming it to
>> vtkSESAMEReader so as not to conflict with paraview.
>>
>> I would prefer the former to avoid duplicating code.
>>
>> Bill
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>



-- 
Unpaid intern in BillsBasement at noware dot com