[vtk-developers] Moved Mirkwood ninja dashboards to nightly

[Bill Lorensen]

Should we ask the cmake folks if ninja is supported? Perhaps they can help.



On Mon, Apr 1, 2013 at 1:56 PM, David Cole <dlrdave at aol.com> wrote:

> OK -- so ninja is not officially supported. And sounds like it will not be
> in the near future either. I can live with that, although it is
> disappointing.
>
> Are jom or nmake officially supported? Or shall I switch to using the
> Visual Studio generator to submit dashboards from this machine?
>
> We may as well abandon the gerrit topic then, and Marcus, thanks for the
> offer, but don't even bother trying... If it's not going to be supported,
> then none of us should waste any more of our time on it.
>
>
> Thanks,
> David C.
>
>
>
> -----Original Message-----
> From: Marcus D. Hanwell <marcus.hanwell at kitware.com>
> To: Bill Lorensen <bill.lorensen at gmail.com>
> Cc: David Cole <dlrdave at aol.com>; VTK Developers <vtk-developers at vtk.org>;
> Berk Geveci <berk.geveci at kitware.com>
> Sent: Mon, Apr 1, 2013 1:38 pm
> Subject: Re: [vtk-developers] Moved Mirkwood ninja dashboards to nightly
>
>
>
> I think supporting a new generator or platform should involve a little
> more than implicitly agreeing by adding a submission to the expected
> section of our dashboards. Several of us knew there were issues with the
> Ninja generator which we hadn't had time/resource to investigate. Whenever
> I tried building VTK with wrapping using Ninja it failed in the same way as
> the mirkwood submissions.
>
>
> Dave Cole should address the comment David Gobbi made on the proposed
> patch, I will give it a try here and see if it works. I don't see any
> sweeping under the rug, in my use of ninja it is clear that the CMake
> support is not as mature and there are still several holes - how many
> should the VTK community be expected to plug? I will take a quick look now,
> and see if things are improved here.
>
>
>
> On Mon, Apr 1, 2013 at 1:08 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
>
>
> I agree with Dave. The defects were introduced by a VTK commit. They
> should be fixed.
>
>
> Bill
>
>
>
>
>
>
> On Mon, Apr 1, 2013 at 1:07 PM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
>
>
>
>
>
>
>
> On Mon, Apr 1, 2013 at 12:53 PM, David Cole <dlrdave at aol.com> wrote:
>
> Fabulous. (Not really, that's email sarcasm.)
>
> It was green until this commit was merged to master:
> http://vtk.org/gitweb?p=VTK.**git;a=commitdiff;h=**
> 34903fe1ba157683efb0062abcc73c**d163d5ff89<http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=34903fe1ba157683efb0062abcc73cd163d5ff89>
>
> Even with python wrapping on, this change would fix it, if we would take
> it: http://review.source.kitware.**com/#/c/10481/<http://review.source.kitware.com/#/c/10481/>
>
> If I just turn python wrapping off, it will also be green again. I will do
> that if we refuse to accept the change I've proposed in gerrit.
>
> I don't think moving it away is the right response when it was green
> before.....
>
> It was working on March 25th. Changes merged to master that day broke it
> for March 26th's dashboard. I object to moving it away and sweeping this
> under the rug. It's a recent break in the VTK master code base, it is not
> an intractable problem with ninja.
>
> If ninja is not officially supported for VTK, then I'll move it to an
> "NMake" or "jom" driven dashboard. I think it's ridiculous *not* to support
> ninja when it's clearly viable and provides the fastest possible build
> times on Windows.
>
>
>
>
> -----Original Message-----
> From: Berk Geveci <berk.geveci at kitware.com>
> To: VTK Developers <vtk-developers at vtk.org>
> Sent: Mon, Apr 1, 2013 11:53 am
> Subject: [vtk-developers] Moved Mirkwood ninja dashboards to nightly
>
>
> Hi folks,
>
>
> I just moved the Mirkwood ninja dashboards from Nightly Expected to
> Nightly. If someone wants to fix the ninja build issues, great. But having
> them in Nightly Expected is not helping us clean the dashboard. As far as I
> am concerned, VTK ninja builds are not officially supported.
>
>
> -berk
>
>
>
> ______________________________**_________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/**
> opensource/opensource.html<http://www.kitware.com/opensource/opensource.html>
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/**listinfo/vtk-developers<http://www.vtk.org/mailman/listinfo/vtk-developers>
>
>
>  _____________________________**__________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/**
> opensource/opensource.html<http://www.kitware.com/opensource/opensource.html>
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/**listinfo/vtk-developers<http://www.vtk.org/mailman/listinfo/vtk-developers>
>
>
>
>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
>
>
>
>
>
> --
> Unpaid intern in BillsBasement at noware dot com
>
>
>
> ______________________________**_________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/**
> opensource/opensource.html<http://www.kitware.com/opensource/opensource.html>
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/**listinfo/vtk-developers<http://www.vtk.org/mailman/listinfo/vtk-developers>
>
>
>
>
>
>
>
>



-- 
Unpaid intern in BillsBasement at noware dot com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20130401/22b37314/attachment.html>