[vtk-developers] Gerrit topics with large numbers of changes

[Philippe Pebay]

Hello Bill

Thanks for your note. I am an atomic-type :) This is a leftover from CVS
times.
In fact I think that VTK still officially recommends atomic commits. Isn't
it so?

Let me see what I can do with this one. But don't worry if you don't have
time, we'll find a way.

Thanks!
Philippe

On Sun, Oct 7, 2012 at 10:, Bill Lorensen <bill.lorensen at gmail.com> wrote:

> Philippe,
>
> First, I think we all appreciate gerrit as a review process. And as a
> gerrit patch contributor, I appreciate how much work it takes to create,
> test and prepare patches for gerrit.
>
> But, as a gerrit reviewer, I find it difficult to do a good job reviewing
> a topic that has almost 20 changes. I've seen several people doing this.
>
> I'm at the other extreme. My topics typically have one change.
>
> There is probably a good intermediate approach.
>
> Question: In this topic, http://review.source.kitware.com/#/t/1415/ ,
> copuld the number of changes been reduced?
>
> Bill
>
>
>
>


-- 
Philippe Pébay, PhD
Director of Visualization and High Performance Computing /
Directeur de la Visualisation et du Calcul Haute Performance
Kitware SAS
26 rue Louis Guérin, 69100 Villeurbanne, France
+33 (0) 6.83.61.55.70 / 4.37.45.04.15
http://www.kitware.fr <http://www.kitware.fr/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20121007/03f4ea0e/attachment.html>