[vtk-developers] Is VTK_USE_METAIO still valid in VTK6?

[Bill Lorensen]

Yes, that's what I meant by the new factory pattern.

For now, I'll push a patch that removes VTK_USE_METAIO. The factory stuff
is a bit above my pay grade right now.

Bill


On Sun, Nov 4, 2012 at 1:12 PM, Marcus D. Hanwell <
marcus.hanwell at kitware.com> wrote:

> On Sun, Nov 4, 2012 at 7:54 AM, Bill Lorensen <bill.lorensen at gmail.com>
> wrote:
> > Folks,
> >
> > The vtkImageReader2Factory fails to register vtkMetaImageReader if
> > VTK_USE_METAIO is not defined. In VTK6, VTK_USE_METAIO is only
> referenced in
> > vtkToolkits.h.in and vtkImageReader2Factory.cxx.
> >
> > Should VTK_USE_METAIO be removed?
> >
> > My guess is that vtkImageReader2Factory needs to be rewritten to use the
> new
> > factory pattern.
> >
> Hi Bill,
>
> It looks like I missed that one, but yes any remaining VTK_USE_ should
> be evaluated as a module should not change its API or implementation
> based on compile flags. There are several exceptions to this in
> rendering where things were too tightly coupled to separate without a
> big rewrite (and little gain).
>
> The approach we took with the SQL modules should work well here
> shouldn't it? I am guessing that is what you mean by new factory
> pattern.
>
> Marcus
>



-- 
Unpaid intern in BillsBasement at noware dot com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20121104/8baa60f3/attachment.html>