[vtk-developers] Merging remove VTK 4 compatibility branch on Wednesday

[Bill Lorensen]

Good to know. I'll abandon my topic. I guess the alternative is to
explicitly define the methods in the derived class and invoke the
superclass' method. Not ideal because if a new method(same name,
different signature)  is added in the base class, the derived classes
will have to be edited again. This is what happened in ITK and we
decided to go with the using declaration.

On Thu, Mar 8, 2012 at 2:28 PM, David Gobbi <david.gobbi at gmail.com> wrote:
> Hi Bill,
>
> Adding "using Superclass::SomeMethod;" to any VTK header will break
> the wrappers... at least until I find time to merge in some additional
> wrapper enhancements.
>
>  - David
>
> On Thu, Mar 8, 2012 at 2:55 PM, Marcus D. Hanwell
> <marcus.hanwell at kitware.com> wrote:
>> I think we have a handle on these now, we have merged in some changes
>> with fixes and will have a better idea when tonight's nightlies
>> submit.
>>
>> On Thu, Mar 8, 2012 at 10:29 AM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>>> You can fix this by adding:
>>>  using Superclass::ExecuteData;
>>> to the classes that are overriding ExecuteData. Likewise for AllocateOutputData.
>>>
>>>
>>> On Thu, Mar 8, 2012 at 9:55 AM, Chris Harris <chris.harris at kitware.com> wrote:
>>>> The two virtual versions of AllocateOutputData(...) in vtkImageAlgorithm are
>>>> also causing errors.
>>>>
>>>> Chris
>>>>
>>>>
>>>> On Thu, Mar 8, 2012 at 9:35 AM, Chris Harris <chris.harris at kitware.com>
>>>> wrote:
>>>>>
>>>>> The two problem case here are:
>>>>>
>>>>> vtkAlgorithm::ExecuteData(vtkDataObject*)’
>>>>> and vtkAlgorithm::ExecuteData(vtkDataObject*, vtkInformation*)
>>>>>
>>>>> vtkAlgorithm::Update(int)’  vtkAlgorithm::Update()
>>>>>
>>>>> I think we need to take another look these to see if we can avoid this
>>>>> hiding.
>>>>>
>>>>> Chris
>>>>>
>>>>>
>>>>> On Wed, Mar 7, 2012 at 3:03 PM, Kyle Lutz <kyle.lutz at kitware.com> wrote:
>>>>>>
>>>>>> On Wed, Mar 7, 2012 at 11:45 AM, Marcus D. Hanwell
>>>>>> <marcus.hanwell at kitware.com> wrote:
>>>>>> > On Mon, Mar 5, 2012 at 2:52 PM, Marcus D. Hanwell
>>>>>> > <marcus.hanwell at kitware.com> wrote:
>>>>>> >> Hi,
>>>>>> >>
>>>>>> >> We think that the remove-vtk-4-compatibility is ready to be merged to
>>>>>> >> master, and plan to make the merge on Wednesday. Berk has described
>>>>>> >> this work previously, and it involves a large number of changes.
>>>>>> >
>>>>>> > This was successfully merged by Brad this morning, right before all
>>>>>> > network access went down in our office (still trying to figure out if
>>>>>> > the two events were related). We are back online now, please let us
>>>>>> > know if you encounter any problems after the merge. You may need to
>>>>>> > rebase any old topics, and ensure you account for the changes
>>>>>> > introduced in this merge to the pipeline and other related areas.
>>>>>> >
>>>>>> > Thanks,
>>>>>> >
>>>>>> > Marcus
>>>>>> > _______________________________________________
>>>>>> > Powered by www.kitware.com
>>>>>> >
>>>>>> > Visit other Kitware open-source projects at
>>>>>> > http://www.kitware.com/opensource/opensource.html
>>>>>> >
>>>>>> > Follow this link to subscribe/unsubscribe:
>>>>>> > http://www.vtk.org/mailman/listinfo/vtk-developers
>>>>>> >
>>>>>>
>>>>>> After pulling from gerrit and re-compiling I started seeing many
>>>>>> overloaded-virtual warnings from GCC (version 4.6.1):
>>>>>>
>>>>>> /home/kyle/VTK/Filtering/vtkAlgorithm.h:379:16: warning: ‘virtual void
>>>>>> vtkAlgorithm::Update(int)’ was hidden [-Woverloaded-virtual]
>>>>>> /home/kyle/VTK/Rendering/vtkPolyDataMapper.h:54:8: warning:   by
>>>>>> ‘virtual void vtkPolyDataMapper::Update()’ [-Woverloaded-virtual]
>>>>>>
>>>>>> The same error is repeated for many (all?) of the classes that inherit
>>>>>> from vtkAlgorithm.
>>>>>>
>>>>>> -kyle
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>



-- 
Unpaid intern in BillsBasement at noware dot com