[vtk-developers] AMREnzoReader valgrind defects

Bill Lorensen bill.lorensen at gmail.com
Tue Jun 5 09:06:56 EDT 2012


George,

Still valgrind issues with the enzo reader. Somehow I messed up your
gerrit patches yesterday and this patch was abandoned:
http://review.source.kitware.com/#/c/6080/

I don't recall doing this but gerrit says I did.

Can you submit a new patch with those std::string changes?

Thanks,

Bill

On Sun, Jun 3, 2012 at 4:06 PM, George Zagaris
<george.zagaris at kitware.com> wrote:
> Thanks Bill. I have a topic that addresses some of that. I will push
> it to Gerrit.
>
> Best,
> George
>
> On Sun, Jun 3, 2012 at 3:32 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> The subject has had valgrind issues for a while:
>> http://open.cdash.org/viewDynamicAnalysisFile.php?id=2759216
>>
>> A quick look shows that some of its methods are returning cstr
>> pointers to local std::strings which is not correct. Perhaps they
>> should be returning std::string"s instead?
>>
>> For example:
>>
>> const char * GetEnzoDirectory( const char * path )
>> {
>> //  int start;
>> //  GetEnzoMajorFileName( path, start );
>>  std::string mydir = vtksys::SystemTools::GetFilenamePath( std::string(path) );
>>  return mydir.c_str( );
>> }
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>



-- 
Unpaid intern in BillsBasement at noware dot com



More information about the vtk-developers mailing list