[vtk-developers] AMREnzoReader valgrind defects

George Zagaris george.zagaris at kitware.com
Sun Jun 3 16:06:04 EDT 2012


Thanks Bill. I have a topic that addresses some of that. I will push
it to Gerrit.

Best,
George

On Sun, Jun 3, 2012 at 3:32 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
> The subject has had valgrind issues for a while:
> http://open.cdash.org/viewDynamicAnalysisFile.php?id=2759216
>
> A quick look shows that some of its methods are returning cstr
> pointers to local std::strings which is not correct. Perhaps they
> should be returning std::string"s instead?
>
> For example:
>
> const char * GetEnzoDirectory( const char * path )
> {
> //  int start;
> //  GetEnzoMajorFileName( path, start );
>  std::string mydir = vtksys::SystemTools::GetFilenamePath( std::string(path) );
>  return mydir.c_str( );
> }
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>



More information about the vtk-developers mailing list