[vtk-developers] ANN: VTK moving to topic reviews in Gerrit on Wednesday

[Jeff Baumes]

When I follow the automatic email link when Marcus added me as a reviewer,
it seems to bring me to the link for reviewing the commit, not the topic.
Can/should we change it to link to the review page for the topic? Otherwise
there really isn't a hint that you need to review the topic.

Jeff

On Fri, Feb 3, 2012 at 12:11 PM, Aashish Chaudhary <
aashish.chaudhary at kitware.com> wrote:

> Hi Chris,
>
> Related to that, is there any plan on adding control on the topic level
> page to see "diff side by side" or "diff all unified"? I think that would
> be very useful, specially if a branch consist of multiple commits.
>
> Thanks,
>
>
> On Fri, Feb 3, 2012 at 11:54 AM, Chris Harris <chris.harris at kitware.com>wrote:
>
>> Hi,
>>
>> Just to clarify the topic view process for people. I have notice a
>> couple of topics have been submitted and people have reviewed them at
>> a change level, which is perfectly valid, however, its the review at
>> the topic level that controls when a topic can be merged. So for
>> example for topic "T23fix-reflection-filter-bug-0012734" the review
>> needs to be perform on this page
>> http://review.source.kitware.com/#/t/23/ to move it into a  state that
>> can be merged.
>>
>> Regards,
>>
>> Chris
>>
>> On Tue, Jan 31, 2012 at 9:38 AM, Marcus D. Hanwell
>> <marcus.hanwell at kitware.com> wrote:
>> > Hi,
>> >
>> > Tomorrow (Wednesday, February 1) we will be updating VTK to enable
>> > full topic based reviews in the Gerrit interface,
>> >
>> > http://review.source.kitware.com/p/VTK
>> >
>> > This means that the VTK topic stage will be disabled, and all commits
>> > must go through Gerrit for review and the topics merged in the Gerrit
>> > interface when they are ready. As part of this change we will also be
>> > adding CDash at Home builds of topic tips for people in the correct
>> > groups in a similar fashion to the builds ITK has benefited from for
>> > quite some time.
>> >
>> > This does mean that there will be some time tomorrow where it is not
>> > possible to merge changes into VTK while we make the switch and verify
>> > that things are working as expected. I will announce on the developer
>> > list when merges will be disabled, along with when they should be back
>> > up and running.
>> >
>> > We have prepared updated instructions for uploading topics, reviewing
>> > and merging changes. I will post links to these instructions shortly.
>> > Brad King, Chris Harris and I will also be on hand to help with any
>> > issues that arise.
>> >
>> > Thanks,
>> >
>> > Marcus
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>
>>
>
>
> --
> | Aashish Chaudhary
> | R&D Engineer
> | Kitware Inc.
> | www.kitware.com
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20120203/4271aef8/attachment.html>