When I follow the automatic email link when Marcus added me as a reviewer, it seems to bring me to the link for reviewing the commit, not the topic. Can/should we change it to link to the review page for the topic? Otherwise there really isn't a hint that you need to review the topic.<div>
<br>
</div><div>Jeff<br><br><div class="gmail_quote">On Fri, Feb 3, 2012 at 12:11 PM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Chris, <div><br></div><div>Related to that, is there any plan on adding control on the topic level page to see "diff side by side" or "diff all unified"? I think that would be very useful, specially if a branch consist of multiple commits. </div>
<div> </div><div>Thanks, </div><div><div><div><br><br><div class="gmail_quote">On Fri, Feb 3, 2012 at 11:54 AM, Chris Harris <span dir="ltr"><<a href="mailto:chris.harris@kitware.com" target="_blank">chris.harris@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
Just to clarify the topic view process for people. I have notice a<br>
couple of topics have been submitted and people have reviewed them at<br>
a change level, which is perfectly valid, however, its the review at<br>
the topic level that controls when a topic can be merged. So for<br>
example for topic "T23fix-reflection-filter-bug-0012734" the review<br>
needs to be perform on this page<br>
<a href="http://review.source.kitware.com/#/t/23/" target="_blank">http://review.source.kitware.com/#/t/23/</a> to move it into a state that<br>
can be merged.<br>
<br>
Regards,<br>
<br>
Chris<br>
<div><div><br>
On Tue, Jan 31, 2012 at 9:38 AM, Marcus D. Hanwell<br>
<<a href="mailto:marcus.hanwell@kitware.com" target="_blank">marcus.hanwell@kitware.com</a>> wrote:<br>
> Hi,<br>
><br>
> Tomorrow (Wednesday, February 1) we will be updating VTK to enable<br>
> full topic based reviews in the Gerrit interface,<br>
><br>
> <a href="http://review.source.kitware.com/p/VTK" target="_blank">http://review.source.kitware.com/p/VTK</a><br>
><br>
> This means that the VTK topic stage will be disabled, and all commits<br>
> must go through Gerrit for review and the topics merged in the Gerrit<br>
> interface when they are ready. As part of this change we will also be<br>
> adding CDash@Home builds of topic tips for people in the correct<br>
> groups in a similar fashion to the builds ITK has benefited from for<br>
> quite some time.<br>
><br>
> This does mean that there will be some time tomorrow where it is not<br>
> possible to merge changes into VTK while we make the switch and verify<br>
> that things are working as expected. I will announce on the developer<br>
> list when merges will be disabled, along with when they should be back<br>
> up and running.<br>
><br>
> We have prepared updated instructions for uploading topics, reviewing<br>
> and merging changes. I will post links to these instructions shortly.<br>
> Brad King, Chris Harris and I will also be on hand to help with any<br>
> issues that arise.<br>
><br>
> Thanks,<br>
><br>
> Marcus<br>
_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a> <br>
</div></div>
<br>_______________________________________________<br>
Powered by <a href="http://www.kitware.com" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at <a href="http://www.kitware.com/opensource/opensource.html" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://www.vtk.org/mailman/listinfo/vtk-developers" target="_blank">http://www.vtk.org/mailman/listinfo/vtk-developers</a><br>
<br>
<br></blockquote></div><br></div>