[vtk-developers] NetCDF mangling, extra underscores?

[David E DeMarle]

We're focussed on 6.0 and not planning a 5.10.1 release. So the
release branch hasn't moved since the release.

David E DeMarle
Kitware, Inc.
R&D Engineer
21 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4909


On Thu, Aug 23, 2012 at 4:06 PM, Sean McBride <sean at rogue-research.com> wrote:
> On Wed, 8 Aug 2012 08:34:43 -0400, Brad King said:
>
>>On 08/07/2012 02:30 PM, David E DeMarle wrote:
>>> Doh! That would be _me.
>>>
>>> I'll apply the patch and watch the dashboards. Thanks for finding it.
>>
>>Did anyone actually try this patch before merging it?  It failed everywhere
>>on the dashboard because the mangling header is not consistently included
>>at the top of every translation unit.  The only way it worked at all before
>>is the extra '_' in the mangling definitions caused them to not work so
>>nothing was really mangled.  I've reverted this for now:
>>
>> http://review.source.kitware.com/#/t/1041/
>> http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=ecfb81fd
>>
>>More work will be needed to fix mangling of vtknetcdf.
>
> Got back from vacation and wow did gerrit send a lot of emails about this topic.  Sorry it caused so much trouble, but glad to see it all fixed.
>
> Is netcdf mangling fixed in the 5.x branch too?
>
> Cheers,
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com
> Mac Software Developer              Montréal, Québec, Canada
>
>