[vtk-developers] NetCDF mangling, extra underscores?

[David E DeMarle]

Doh! That would be _me.

I'll apply the patch and watch the dashboards. Thanks for finding it.

David E DeMarle
Kitware, Inc.
R&D Engineer
21 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-881-4909


On Tue, Aug 7, 2012 at 2:16 PM, Sean McBride <sean at rogue-research.com> wrote:
> Hi all,
>
> I'm having some link errors in my app after updating some of my dependences (specifically NetCDF, ITK, VTK, etc.).
>
> I think vtk_netcdf_mangle.h has some mistakes...  some functions start with underscore and some do not, ex:
>
> #define _nc_get_att_uint vtk_netcdf__nc_get_att_uint
>
> vs
>
> #define nc_get_att_int vtk_netcdf_nc_get_att_int
>
> OS X prepends symbols with underscore, so I suspect someone (hopefully it wasn't me, hehe) ran the procedures to generate vtk_netcdf_mangle.h on OS X but forget to remove those underscores.
>
> My untested patch is here:
> <http://review.source.kitware.com/6868>
>
> Sorry for not testing, but I have a flight to catch... If someone approves/applies this, could you do so in the 5.x branch too?
>
> Thanks,
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com
> Mac Software Developer              Montréal, Québec, Canada
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>