[vtk-developers] Patch for vtkCocoaRenderWindowInteractor TerminateApp behavior

Marcus D. Hanwell marcus.hanwell at kitware.com
Tue Aug 7 13:54:33 EDT 2012


On Tue, Aug 7, 2012 at 1:50 PM, Sean McBride <sean at rogue-research.com> wrote:
> On Fri, 3 Aug 2012 19:11:55 -0400, Pat Marion said:
>
>>Anyway, I appreciate you taking the time to look over the patch details!
>>If we decide to proceed with the patch, you said some more changes might be
>>needed, any hints what those might be?
>
> Sorry for not elaborating, I was just leaving work when I wrote that.  And now I'm off on vacation for two weeks.  :(
>
> I don't object to you committing this as is for now.  When I get back, I can expand on your change.  Basically, from what you're saying we don't need any of that code that terminates the process, ever. Also, we should review when we register/unregister for window closing notifications.  Currently the start and stop methods are not very symmetric, IIRC.
>
> If you do commit, I suggest you update the doxy comments for TerminateApp() at the same time.
>
I think ideally we should add new API to more cleanly accomplish a
process events call, but as the other implementations all behave in a
certain way consistency seems reasonable. I talked with Radu in the
past about what they were doing, and how it was not necessarily the
intended behavior of those functions (but it did work for them).

If people are happy with the change, it seems like this will help out
a set of VTK users without impacting other projects.

Marcus



More information about the vtk-developers mailing list