[vtk-developers] vtkSelectVisiblePoints on empty data set

[Andreas Buykx]

Hi Dave, and vtk-developers,

Here’s the patch. Because there are not Cxx tests with vtkSelectVisiblePoints in VTK, and we don’t have Tcl, I tried it in our application where it had exactly the expected behavior: no error messages anymore as the ones described below, and visible points selected as before.

In what release will this patch appear? We use the latest release 5.6.1, but your nightly build is already 5.9!

Thanks,
Andreas

From: David E DeMarle [mailto:dave.demarle at kitware.com]
Sent: Tuesday, June 07, 2011 2:31 PM
To: Andreas Buykx
Cc: vtk-developers at vtk.org
Subject: Re: [vtk-developers] vtkSelectVisiblePoints on empty data set

That is probably an oversight. Try changing the vtkSelectVisiblePoints::RequestData to do an early check for empty input dataset and make it produce an empty output dataset and return 1.

If that change doesn't break any regression tests on your machine please send the patch to the list and we'll push it to the repository.

David E DeMarle
Kitware, Inc.
R&D Engineer
28 Corporate Drive
Clifton Park, NY 12065-8662
Phone: 518-371-3971 x109

2011/6/4 Andreas Buykx <A.Buykx at tnodiana.com<mailto:A.Buykx at tnodiana.com>>
Hi all,

I have a pipeline in my application that should display the ids of visible points, using a.o. the vtkSelectVisiblePoints filter. The input to this filter is a – possibly empty - selection of the original data set.
When the set is in fact empty, I get a lot of the following errors:
ERROR: In <path-deleted>/VTK/src/Filtering/vtkExecutive.cxx, line 753
vtkStreamingDemandDrivenPipeline (0x32b8700): Algorithm vtkSelectVisiblePoints(0x3168ea0) returned failure for request: vtkInformation (0x3340180)
  Debug: Off
  Modified Time: 23448
  Reference Count: 1
  Registered Events: (none)
  Request: REQUEST_DATA
  FROM_OUTPUT_PORT: 0
  FORWARD_DIRECTION: 0
  ALGORITHM_AFTER_FORWARD: 1

I looked in the code and found that this filter returns a 0 from RequestData if the input dataset is empty. In my situation an empty input dataset is a valid input condition and I’d like to prevent all these errors. What are my options?

Thanks for your help!
Andreas Buykx
Senior Software Engineer

TNO DIANA BV
Software Developers and Analysis Consultants for Civil and Geotechnical Engineering

Delftechpark 19a, 2628 XJ, Delft, The Netherlands
Tel: +31 88 34262 15<tel:%2B31%2088%2034262%2015> (Direct) │ Tel: +31 88 34262 00<tel:%2B31%2088%2034262%2000> (Switchboard) │ +31 88 34262 99<tel:%2B31%2088%2034262%2099> (Fax)
http://tnodiana.com<http://tnodiana.com/>

…be green keep it on screen

____________________________________________________________
TNO DIANA BV is a limited liability company registered in the trade register of the Chamber of Commerce as TNO DIANA BV with registered number 27252655.
____________________________________________________________
This e-mail and its contents are subject to the DISCLAIMER at http://tnodiana.com/content/Disclaimer
____________________________________________________________

_______________________________________________
Powered by www.kitware.com<http://www.kitware.com>

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers


____________________________________________________________
TNO DIANA BV is a limited liability company registered in the trade register of the Chamber of Commerce as TNO DIANA BV with registered number 27252655.
____________________________________________________________
This e-mail and its contents are subject to the DISCLAIMER at http://tnodiana.com/content/Disclaimer
____________________________________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20110608/d96ccee6/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vtkSelectVisiblePoints.cxx.patch
Type: application/octet-stream
Size: 769 bytes
Desc: vtkSelectVisiblePoints.cxx.patch
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20110608/d96ccee6/attachment-0001.obj>