[vtk-developers] Warning in vtkExtractSelectedIds

[David Doria]

On Fri, Dec 30, 2011 at 3:44 PM, David Gobbi <david.gobbi at gmail.com> wrote:
> The more that I look at it, the more convinced I am that the outer loop
> is not even supposed to be there.
>
>  860         for (vtkIdType j = 0; j < input->GetNumberOfPoints(); j++)
>
> http://vtk.org/gitweb?p=VTK.git;a=blob;f=Graphics/vtkExtractSelectedIds.cxx;hb=ecbbf7f7#l860
>
> Take a look at the commit where this line was added:
> http://vtk.org/gitweb?p=VTK.git;a=commitdiff;h=7030e24d#patch5
>
> You have to scroll down some to see the line, but when this line was
> first added it was missing curly braces and it really looks as if the
> whole line is just a big typo.
>
>  - David

Once the patch is ready, we should probably also add a test:

~/src/VTK/Graphics/Testing/Cxx$ grep -ri "ExtractSelectedIds" .
~/src/VTK/Graphics/Testing/Cxx$

I just wrote this demo:
http://www.vtk.org/Wiki/VTK/Examples/Cxx/PolyData/ExtractSelectedIds

It could be used as a starting point for a simple test.