[vtk-developers] Valgrind defects are zero!

David Doria daviddoria at gmail.com
Thu Dec 8 14:33:35 EST 2011


> We support too many platforms and options to be able to cover all possibilities.

Of course we can't cover ALL possible configurations. However, the
only defects we know about (the ones you fixed) are the platforms we
test for. Therefore it seems to make sense to only allow new code that
does not introduce problems on platforms we support/test, right?

> Also, ITK has 3 robot builds that are kicked off for each gerrit patch.

Right, but the *assumption* is that the human reviewers will look at
this, which may or may not happen in practice. What I am suggesting is
that these robot builds report back to gerrit (as "robot reviewers")
and flag the patch as "not approved" if anything fails/has defects.

> This certainly helps but does not eliminate the introduction of defects.

My proposal *eliminates* the introduction of defects on platforms we
test, which is really the best we can hope to do.



More information about the vtk-developers mailing list