[vtk-developers] BUG: vtkImageActor - set of ComputedDisplayExtent variable.

[Pokutnev, Pavel (GE EntSol, SensInsp)]

Hello David,
 
thanks for the quick responce! I found this inconstancy just by browsing
the code as i was looking for the reason of cutted edge pixels. See this
example with screnshot:
 
http://www.vtk.org/Wiki/VTK/Examples/Images/PickingAPixel2
 
So it was just my assumption that those lines can be incorrect.
 
Best regards!
 
________________________________

Von: Dave Partyka [mailto:dave.partyka at kitware.com] 
Gesendet: Mittwoch, 14. Juli 2010 15:40
An: David Cole
Cc: Pokutnev, Pavel (GE EntSol, SensInsp); vtk-developers at vtk.org
Betreff: Re: [vtk-developers] BUG: vtkImageActor - set of
ComputedDisplayExtent variable.


Hi Pavel, I am curious how you discovered this bug. Were you just
browsing through the file or do you have code that is affected by this?
If so would you mind sharing it? I would like to make a test out of it
if possible.


On Wed, Jul 14, 2010 at 9:26 AM, Dave Partyka <dave.partyka at kitware.com>
wrote:


	Those lines are definitely covered. Though it appears the only
are used when the extents haven't been set yet. 

	
http://www.cdash.org/CDash/viewCoverageFile.php?buildid=663956&fileid=10
980615 


	On Wed, Jul 14, 2010 at 9:18 AM, David Cole
<david.cole at kitware.com> wrote:
	

		This sort of error looks like it should produce some
sort of seriously incorrect results. 

		Do we not have a test that covers this code? Is the
coverage for the lines in question "0" or do we just not have a *good*
test that runs through that code...?

		I would think vtkImageActor is a heavily used class.


		?


		On Wed, Jul 14, 2010 at 8:51 AM, Dave Partyka
<dave.partyka at kitware.com> wrote:
		

			Thanks for the fix! I have just committed it.
			
			
			On Wed, Jul 14, 2010 at 4:19 AM, Pokutnev, Pavel
(GE EntSol, SensInsp) <Pavel.Pokutnev at ge.com> wrote:
			

				Hello vtk-devs,
				 
				it looks like there is a copy & paste
bug in vtkImageActor line 250 and 293:
				 
				The line:
				  this->ComputedDisplayExtent[5] =
wExtent[4];
				should be:
				  this->ComputedDisplayExtent[5] =
wExtent[5];
				 
				Best regards!
				 
				 
				

				 

	
_______________________________________________
				Powered by www.kitware.com
				
				Visit other Kitware open-source projects
at http://www.kitware.com/opensource/opensource.html
				
				Follow this link to
subscribe/unsubscribe:
	
http://www.vtk.org/mailman/listinfo/vtk-developers
				
				
				



			_______________________________________________
			Powered by www.kitware.com
			
			Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html
			
			Follow this link to subscribe/unsubscribe:
	
http://www.vtk.org/mailman/listinfo/vtk-developers
			
			
			




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20100714/4b14c928/attachment.html>