<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=us-ascii" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18928"></HEAD>
<BODY>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=176184513-14072010>Hello David,</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=176184513-14072010></SPAN></FONT> </DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=176184513-14072010>thanks for the quick responce! I found this inconstancy
just by browsing the code as i was looking for the reason of cutted edge pixels.
See this example with screnshot:</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=176184513-14072010></SPAN></FONT> </DIV>
<DIV dir=ltr align=left><FONT color=#0000ff><SPAN class=176184513-14072010><A
href="http://www.vtk.org/Wiki/VTK/Examples/Images/PickingAPixel2">http://www.vtk.org/Wiki/VTK/Examples/Images/PickingAPixel2</A></SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=176184513-14072010></SPAN></FONT> </DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=176184513-14072010>So it was just my assumption that those lines can be
incorrect.</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=176184513-14072010></SPAN></FONT> </DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=176184513-14072010>Best regards!</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=176184513-14072010></SPAN></FONT> </DIV>
<DIV dir=ltr align=left>
<HR tabIndex=-1>
</DIV>
<DIV dir=ltr align=left><FONT size=2 face=Tahoma><B>Von:</B> Dave Partyka
[mailto:dave.partyka@kitware.com] <BR><B>Gesendet:</B> Mittwoch, 14. Juli 2010
15:40<BR><B>An:</B> David Cole<BR><B>Cc:</B> Pokutnev, Pavel (GE EntSol,
SensInsp); vtk-developers@vtk.org<BR><B>Betreff:</B> Re: [vtk-developers] BUG:
vtkImageActor - set of ComputedDisplayExtent variable.<BR></FONT><BR></DIV>
<DIV></DIV>Hi Pavel, I am curious how you discovered this bug. Were you just
browsing through the file or do you have code that is affected by this? If so
would you mind sharing it? I would like to make a test out of it if
possible.<BR><BR>
<DIV class=gmail_quote>On Wed, Jul 14, 2010 at 9:26 AM, Dave Partyka <SPAN
dir=ltr><<A
href="mailto:dave.partyka@kitware.com">dave.partyka@kitware.com</A>></SPAN>
wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>Those lines are definitely covered. Though it
appears the only are used when the extents haven't been set yet.
<DIV><BR></DIV>
<DIV><A
href="http://www.cdash.org/CDash/viewCoverageFile.php?buildid=663956&fileid=10980615"
target=_blank>http://www.cdash.org/CDash/viewCoverageFile.php?buildid=663956&fileid=10980615</A>
<DIV>
<DIV></DIV>
<DIV class=h5><BR><BR>
<DIV class=gmail_quote>On Wed, Jul 14, 2010 at 9:18 AM, David Cole <SPAN
dir=ltr><<A href="mailto:david.cole@kitware.com"
target=_blank>david.cole@kitware.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>This sort of error looks like it should produce some sort
of seriously incorrect results.
<DIV><BR></DIV>
<DIV>Do we not have a test that covers this code? Is the coverage for the
lines in question "0" or do we just not have a *good* test that runs through
that code...?</DIV>
<DIV><BR></DIV>
<DIV>I would think vtkImageActor is a heavily used class.</DIV>
<DIV><BR></DIV>
<DIV><BR>?</DIV>
<DIV>
<DIV></DIV>
<DIV>
<DIV><BR></DIV>
<DIV><BR>
<DIV class=gmail_quote>On Wed, Jul 14, 2010 at 8:51 AM, Dave Partyka <SPAN
dir=ltr><<A href="mailto:dave.partyka@kitware.com"
target=_blank>dave.partyka@kitware.com</A>></SPAN> wrote:<BR>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>Thanks for the fix! I have just committed it.<BR><BR>
<DIV class=gmail_quote>
<DIV>
<DIV></DIV>
<DIV>On Wed, Jul 14, 2010 at 4:19 AM, Pokutnev, Pavel (GE EntSol,
SensInsp) <SPAN dir=ltr><<A href="mailto:Pavel.Pokutnev@ge.com"
target=_blank>Pavel.Pokutnev@ge.com</A>></SPAN> wrote:<BR></DIV></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #ccc 1px solid; MARGIN: 0px 0px 0px 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV>
<DIV></DIV>
<DIV>
<DIV>
<DIV><FONT size=2 face=Arial><SPAN>Hello vtk-devs,</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial><SPAN></SPAN></FONT> </DIV>
<DIV><FONT size=2 face=Arial><SPAN>it looks like there is a copy &
paste bug in vtkImageActor line 250 and 293:</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial><SPAN></SPAN></FONT> </DIV>
<DIV><FONT size=2 face=Arial><SPAN>The line:</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial><SPAN>
this->ComputedDisplayExtent[5] = wExtent[4];</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial><SPAN>should be:</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial><SPAN>
this->ComputedDisplayExtent[5] = wExtent[5];</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial><SPAN></SPAN></FONT> </DIV>
<DIV><FONT size=2 face=Arial><SPAN>Best regards!</SPAN></FONT></DIV>
<DIV><FONT size=2 face=Arial><SPAN></SPAN></FONT> </DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV><FONT size=2 face=Arial>
<DIV align=left><BR></DIV></FONT>
<DIV><FONT size=2
face=Arial></FONT> </DIV></DIV><BR></DIV></DIV>_______________________________________________<BR>Powered
by <A href="http://www.kitware.com"
target=_blank>www.kitware.com</A><BR><BR>Visit other Kitware open-source
projects at <A href="http://www.kitware.com/opensource/opensource.html"
target=_blank>http://www.kitware.com/opensource/opensource.html</A><BR><BR>Follow
this link to subscribe/unsubscribe:<BR><A
href="http://www.vtk.org/mailman/listinfo/vtk-developers"
target=_blank>http://www.vtk.org/mailman/listinfo/vtk-developers</A><BR><BR><BR></BLOCKQUOTE></DIV><BR><BR>_______________________________________________<BR>Powered
by <A href="http://www.kitware.com"
target=_blank>www.kitware.com</A><BR><BR>Visit other Kitware open-source
projects at <A href="http://www.kitware.com/opensource/opensource.html"
target=_blank>http://www.kitware.com/opensource/opensource.html</A><BR><BR>Follow
this link to subscribe/unsubscribe:<BR><A
href="http://www.vtk.org/mailman/listinfo/vtk-developers"
target=_blank>http://www.vtk.org/mailman/listinfo/vtk-developers</A><BR><BR><BR></BLOCKQUOTE></DIV><BR></DIV></DIV></DIV></BLOCKQUOTE></DIV><BR></DIV></DIV></DIV></BLOCKQUOTE></DIV><BR></BODY></HTML>