[vtk-developers] Changes to vtkPlane broke build

[Berk Geveci]

> By anonymous namespace, do you mean this:
>
> namespace
> {
>  //functions
> }

Yes.


On Thu, Jan 7, 2010 at 2:11 PM, David Doria <daviddoria+vtk at gmail.com> wrote:
> On Thu, Jan 7, 2010 at 12:33 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> I don't see and broken builds on the VTK dashboard (Nightly Expected).
>> Shouldn't the nightlies (or better yet a continuous) VTK build detect
>> this sort of defect.
>>
>> Bill
>>
>> On Thu, Jan 7, 2010 at 10:53 AM, Berk Geveci <berk.geveci at kitware.com> wrote:
>>> I took at the code and the functionality is very cool. It just needs
>>> to find another home :-) Maybe a new utility class in Filtering or
>>> even a filter. (Thinking about it, maybe implicit functions should
>>> subclass from vtkDataObject?)
>>>
>>> Another comment, I noticed the CenterOfMass and create_matrix are
>>> polluting the global namespace. You should put them in an anonymous
>>> namespace instead. Also, create_matrix does not follow VTK's naming
>>> conventions, please fix that.
>>>
>>> I am going the revert this commit for now. Let me or Karthik know when
>>> you have a fix.
>>>
>>> Best,
>>> -berk
>>>
>>> On Thu, Jan 7, 2010 at 10:14 AM, David Doria <daviddoria+vtk at gmail.com> wrote:
>>>> On Thu, Jan 7, 2010 at 10:04 AM, Berk Geveci <berk.geveci at kitware.com> wrote:
>>>>> Hi Karthik and David,
>>>>>
>>>>> Karthik's commit to vtkPlane broke some builds. I noticed that
>>>>> vtkPlane is now referring to vtkDataSet. It can't do that since
>>>>> vtkPlane is in Common and vtkDataSet is in Filtering. Please fix this
>>>>> somehow (without moving vtkPlane to Filtering).
>>>>>
>>>>> -berk
>>>>>
>>>>
>>>> Guys,
>>>>
>>>> I am travelling today. I can look at it first thing tomorrow if
>>>> Karthik doesn't get to it first. I wasn't aware that it is illegal to
>>>> use things from different libraries? Why is this the case?
>>>>
>>>> Thanks,
>>>>
>>>> David
>>>> _______________________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>>
>>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.vtk.org/mailman/listinfo/vtk-developers
>>>
>>>
>>
>
> By anonymous namespace, do you mean this:
>
> namespace
> {
>  //functions
> }
>
> Also, what do I need to do to my build (linux,gcc) so this problem
> will show up (so I know when I've made it go away :) )? Or is it only
> with windows DLLs?
>
> Thanks,
>
> David
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>