[vtk-developers] [ParaView3-Developer] Uploading full test images to CDash

[Moreland, Kenneth]

I have not made all of the images full size, but that is an easy change to make.

-Ken


On 5/20/09 4:44 AM, "David Cole" <david.cole at kitware.com> wrote:

Go for it unless somebody has an objection. Since CDash hashes images, it will only store one copy of each image and many dashboards will reference each one. That eliminates the need for keeping the images sent to the server small.

The one comment I have is this: we may want to consider keeping all images the same size for a given test (valid, test, diff) so that your brain can visually compare them better. So we may want to make the other images full size as well. (Or does this change already do that? I don't think so, but I was only reading through the diff...)


Nice work...,
David


On Tue, May 19, 2009 at 7:08 PM, Moreland, Kenneth <kmorel at sandia.gov> wrote:
Although I try to avoid it, occasionally I create or modify a test that requires multiple baseline images because different GPUs will generate images with enough differences.  Doing this is easy enough (just check in the extra baseline images), but I don't have access to most of the VTK and ParaView dashboards.  In order to get the image, I have to track down someone with access to the machine and ask them to check in the image for me.

In my mind it is backwards to have the dashboard maintainer making the decision on whether a test legitimately failed or has innocuous image differences.  Rather, the person creating the test should make the determination.  Thus, it makes sense for the image to be uploaded to the dashboard where everyone, most importantly the test coder, has access, can download a copy, and check in a new baseline.

I recently met some of the CMake/CDash developers and asked them for this feature.  They told me the functionality is already in CDash; I only need to instruct CTest to upload the files I want to show up.  As it turns out, with only a couple of small changes I can implement this in VTK (and by proxy in ParaView).  The attached VTK patch implements the full image upload.  Are there any objections to checking this in?

-Ken

   ****      Kenneth Moreland
    ***      Sandia National Laboratories
***********
*** *** ***  email: kmorel at sandia.gov <http://kmorel@sandia.gov>
**  ***  **  phone: (505) 844-8919
    ***      web:   http://www.cs.unm.edu/~kmorel <http://www.cs.unm.edu/%7Ekmorel>


_______________________________________________
ParaQ-Developer mailing list
ParaQ-Developer at paraview.org
http://public.kitware.com/cgi-bin/mailman/listinfo/paraq-developer




   ****      Kenneth Moreland
    ***      Sandia National Laboratories
***********
*** *** ***  email: kmorel at sandia.gov
**  ***  **  phone: (505) 844-8919
    ***      web:   http://www.cs.unm.edu/~kmorel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20090520/aa8dffb7/attachment.html>