[vtk-developers] Testing utilities

Shepherd, Jason F jfsheph at sandia.gov
Fri Oct 31 10:52:15 EDT 2008


Thanks, David.  I'll make the change over the next couple of days and see how the tests respond...

Thanks!

Jason

________________________________
From: David Cole [mailto:david.cole at kitware.com]
Sent: Thursday, October 30, 2008 5:42 PM
To: Shepherd, Jason F
Cc: vtk-developers at vtk.org
Subject: Re: [vtk-developers] Testing utilities

No legitimate reason that I can think of...

Feel free to add it in ExpandDataFileName as long as all the tests still pass. (Can't see why they wouldn't...) Just keep an eye on the dashboards after your commits. Actually, why not just make vtkTestUtilities call vtkTesting::GetDataRoot and eliminate the code duplication...?


Thanks,
David Cole


2008/10/30 Shepherd, Jason F <jfsheph at sandia.gov<mailto:jfsheph at sandia.gov>>
Hey guys,

I've noticed that there are (seemingly) two ways of getting to the VTKData directory from a test file:

vtkTestUtilities::ExpandDataFileName(...)
and
vtkTesting::GetDataRoot()

The first one looks for a command line argument, then for a VTK_DATA_ROOT environment variable, and failing those uses "../../../../VTKData".
The second option looks for a command line argument, then for a VTK_DATA_ROOT environment variable, then a CMAKE variable (VTK_DATA_ROOT, again), and failing those applies "../../../../VTKData".

Is there a reason for not checking for the CMAKE variable in ExpandDataFileName() ?

Jason Shepherd



_______________________________________________
vtk-developers mailing list
vtk-developers at vtk.org<mailto:vtk-developers at vtk.org>
http://www.vtk.org/mailman/listinfo/vtk-developers


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/vtk-developers/attachments/20081031/19e3d705/attachment.html>


More information about the vtk-developers mailing list