<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=Content-Type content="text/html; charset=us-ascii">
<META content="MSHTML 6.00.2900.3429" name=GENERATOR></HEAD>
<BODY>
<DIV dir=ltr align=left><SPAN class=630055114-31102008><FONT face=Arial
color=#0000ff size=2>Thanks, David. I'll make the change over the next
couple of days and see how the tests respond...</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=630055114-31102008><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=630055114-31102008><FONT face=Arial
color=#0000ff size=2>Thanks!</FONT></SPAN></DIV>
<DIV dir=ltr align=left><SPAN class=630055114-31102008><FONT face=Arial
color=#0000ff size=2></FONT></SPAN> </DIV>
<DIV dir=ltr align=left><SPAN class=630055114-31102008><FONT face=Arial
color=#0000ff size=2>Jason</FONT></SPAN></DIV><BR>
<BLOCKQUOTE
style="PADDING-LEFT: 5px; MARGIN-LEFT: 5px; BORDER-LEFT: #0000ff 2px solid; MARGIN-RIGHT: 0px">
<DIV class=OutlookMessageHeader lang=en-us dir=ltr align=left>
<HR tabIndex=-1>
<FONT face=Tahoma size=2><B>From:</B> David Cole
[mailto:david.cole@kitware.com] <BR><B>Sent:</B> Thursday, October 30, 2008
5:42 PM<BR><B>To:</B> Shepherd, Jason F<BR><B>Cc:</B>
vtk-developers@vtk.org<BR><B>Subject:</B> Re: [vtk-developers] Testing
utilities<BR></FONT><BR></DIV>
<DIV></DIV>No legitimate reason that I can think of...<BR><BR>Feel free to add
it in ExpandDataFileName as long as all the tests still pass. (Can't see why
they wouldn't...) Just keep an eye on the dashboards after your commits.
Actually, why not just make vtkTestUtilities call vtkTesting::GetDataRoot and
eliminate the code duplication...?<BR><BR><BR>Thanks,<BR>David
Cole<BR><BR><BR>
<DIV class=gmail_quote>2008/10/30 Shepherd, Jason F <SPAN dir=ltr><<A
href="mailto:jfsheph@sandia.gov">jfsheph@sandia.gov</A>></SPAN><BR>
<BLOCKQUOTE class=gmail_quote
style="PADDING-LEFT: 1ex; MARGIN: 0pt 0pt 0pt 0.8ex; BORDER-LEFT: rgb(204,204,204) 1px solid">
<DIV><FONT face="Arial, sans-serif" size=2>
<DIV>Hey guys,</DIV>
<DIV> </DIV>
<DIV>I've noticed that there are (seemingly) two ways of getting to the
VTKData directory from a test file:</DIV>
<DIV> </DIV>
<DIV>vtkTestUtilities::ExpandDataFileName(…)</DIV>
<DIV>and</DIV>
<DIV>vtkTesting::GetDataRoot()</DIV>
<DIV> </DIV>
<DIV>The first one looks for a command line argument, then for a
VTK_DATA_ROOT environment variable, and failing those uses
"../../../../VTKData".</DIV>
<DIV>The second option looks for a command line argument, then for a
VTK_DATA_ROOT environment variable, then a CMAKE variable (VTK_DATA_ROOT,
again), and failing those applies "../../../../VTKData".</DIV>
<DIV> </DIV>
<DIV>Is there a reason for not checking for the CMAKE variable in
ExpandDataFileName() ?</DIV>
<DIV> </DIV>
<DIV>Jason Shepherd</DIV>
<DIV> </DIV>
<DIV> </DIV></FONT></DIV><BR>_______________________________________________<BR>vtk-developers
mailing list<BR><A
href="mailto:vtk-developers@vtk.org">vtk-developers@vtk.org</A><BR><A
href="http://www.vtk.org/mailman/listinfo/vtk-developers"
target=_blank>http://www.vtk.org/mailman/listinfo/vtk-developers</A><BR><BR></BLOCKQUOTE></DIV><BR></BLOCKQUOTE></BODY></HTML>