[vtk-developers] gcc warnings about empty if/while bodies

John Biddiscombe biddisco at cscs.ch
Tue Jun 17 02:55:55 EDT 2008


> I like it.  And this warning is not so useless after all.  Check what it
> found:
>
> void DICOMParser::AddDICOMTagCallbackToAllTags(DICOMCallback* cb)
> {
>   DICOMParserMap::iterator miter;
>   for (miter = Implementation->Map.begin();
>        miter != Implementation->Map.end();
>        miter++);
>   {
>   dicom_stl::vector<DICOMCallback*>* callbacks = (*miter).second.second;
>   callbacks->push_back(cb);
>   }
> }
>
> Highly suspicious.  Can anyone say for sure if that ; should be there?
it _must_ be a mistake. the reference to (*miter).second.second; would 
be utterly meaningless otherwise - as would the whole function!

JB

-- 
John Biddiscombe,                            email:biddisco @ cscs.ch
http://www.cscs.ch/about/BJohn.php
CSCS, Swiss National Supercomputing Centre  | Tel:  +41 (91) 610.82.07
Via Cantonale, 6928 Manno, Switzerland      | Fax:  +41 (91) 610.82.82





More information about the vtk-developers mailing list