[vtk-developers] gcc warnings about empty if/while bodies

Sean McBride sean at rogue-research.com
Mon Jun 16 19:57:51 EDT 2008


On 6/16/08 7:51 PM, Will Schroeder said:

>yes, I know it's verbose and terribly ugly but it does come in handy at
>times...

I like it.  And this warning is not so useless after all.  Check what it
found:

void DICOMParser::AddDICOMTagCallbackToAllTags(DICOMCallback* cb)
{
  DICOMParserMap::iterator miter;
  for (miter = Implementation->Map.begin();
       miter != Implementation->Map.end();
       miter++);
  {
  dicom_stl::vector<DICOMCallback*>* callbacks = (*miter).second.second;
  callbacks->push_back(cb);
  }
}

Highly suspicious.  Can anyone say for sure if that ; should be there?

-- 
____________________________________________________________
Sean McBride, B. Eng                 sean at rogue-research.com
Rogue Research                        www.rogue-research.com 
Mac Software Developer              Montréal, Québec, Canada




More information about the vtk-developers mailing list