[vtk-developers] vtkPolyData->IsEdge fix

[John Biddiscombe]

Make the change, run all the tests and see how many break. If none, then commit the fix (after asking the ARB yes?), if some, then see if the tests are actually wrong and need to be changed.

JB

IsEdge should return a true edge (why fool people), but maybe you could add IsUsedBy (or similar) to mimic the existing bug?


-----Original Message-----
From: Rasmus Reinhold Paulsen [mailto:rrp at imm.dtu.dk]
Sent: 11 March 2003 10:17
To: lucantiga at softhome.net
Cc: vtk-developers
Subject: Re: [vtk-developers] vtkPolyData->IsEdge fix



On Mon, 10 Mar 2003 lucantiga at softhome.net wrote:

> Hi Rasmus,
>  I'm glad you raised the issue. Actually please replace 
> >         if ((pts[(j-1)%npts]==p2)||(pts[(j+1)%npts]==p2))
> with 
> >         if (pts[(j+1)%npts]==p2)
>  for the fix.
> 
> Luca

On second thought I am really scared of changing such an ancient
"feature", it could change the results of computations the most unexpected
places. A solution would be to update the documentation of IsEdge and add
another method, that can be used for n-sided polys. But what should it be
called? IsTruePolyEdge? IsNSidedPolyEdge?

Regards,
Rasmus

_______________________________________________
vtk-developers mailing list
vtk-developers at public.kitware.com
http://public.kitware.com/mailman/listinfo/vtk-developers