[Tubetk-developers] Code review

[Matt McCormick]

Hi Stephen,

Catching up here with the code review, but these were some good updates.

I needed to add the same Qt version check setup used by Slicer for my system:

http://tubetk.org/gitweb?p=TubeTK.git;a=commit;h=3dcee041c740dda4e732e5ca5343455ad1d6e563

so that the Qt version check can be overridden.  My Slicer build does
not work with 4.7.2 but requires 4.8.2.

Thanks,
Matt


On Tue, Nov 27, 2012 at 2:29 AM, Stephen Aylward
<stephen.aylward at kitware.com> wrote:
> Hi,
>
> Now that TubeTK is getting more stable and attention, should we do
> code reviews prior to moving from stage to master?
>
> If so, I have two pending for moves to Master from Stage.  Matt or
> Roland do you want to review them:
>
> CheckQTVersion - addresses Bug
> http://public.kitware.com/Bug/view.php?id=13607
>
> AutoBuildCMake - addresses Bug
> http://public.kitware.com/Bug/view.php?id=13744
>
> Stephen
> --
>
> ==============================
> Stephen R. Aylward, Ph.D.
> Senior Director of Operations - North Carolina
> Kitware, Inc. - North Carolina Office
> http://www.kitware.com
> stephen.aylward (Skype)
> (919) 969-6990 x300
> _______________________________________________
> Tubetk-developers mailing list
> Tubetk-developers at tubetk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/tubetk-developers