[Paraview-developers] Selection Changes in ParaView Master

[Mathieu Westphal]

Hi

Well i can, but is it worth it ? this typedef has been alive for merely two
months.
However i did not know about this page and will use it in the future.

Should I had new api changes in a new section ? Changes in git master ?
Changes in paraview 5?

Mathieu

Mathieu Westphal

On Fri, Oct 9, 2015 at 5:37 PM, Utkarsh Ayachit <utkarsh.ayachit at kitware.com
> wrote:

> Mathieu,
>
> Can we document this here:
>
> https://gitlab.kitware.com/paraview/paraview/blob/master/Utilities/Doxygen/pages/MajorAPIChanges.md
> .
>
> This gets rendered by Doxygen here:
>
> http://www.paraview.org/ParaView3/Doc/Nightly/www/cxx-doc/MajorAPIChanges.html
>
> On Fri, Oct 9, 2015 at 4:14 AM, Mathieu Westphal
> <mathieu.westphal at kitware.com> wrote:
> > Hi
> >
> > There is no more typedef, it is only an int corresponding to the enum in
> > pqView.h
> >
> > Selection have been standardized for all kind of view, Render or Context
> >
> > Mathieu Westphal
> >
> > On Thu, Oct 8, 2015 at 6:55 PM, Bob Obara <bob.obara at kitware.com> wrote:
> >>
> >> Hi Mathieu,
> >>
> >> Thanks for getting back to me on this.
> >>
> >> Where is the pqSelectionOperator class now defined?  Its no longer part
> of
> >> the pqRenderView class?
> >>
> >> Bob
> >>
> >> On Thu, Oct 8, 2015 at 12:12 PM, Mathieu Westphal
> >> <mathieu.westphal at kitware.com> wrote:
> >>>
> >>> Hi
> >>>
> >>> Indeed, see pqView.h ( as hinted by your compiler error )
> >>>
> >>>   enum SelectionModifier {
> >>>     PV_SELECTION_DEFAULT = 0,
> >>>     PV_SELECTION_ADDITION,
> >>>     PV_SELECTION_SUBTRACTION,
> >>>     PV_SELECTION_TOGGLE
> >>>   };
> >>>
> >>> so
> >>> pqRenderView::PV_SELECTION_MERGE -> pqView::PV_SELECTION_ADDITION,
> >>> pqRenderView::PV_SELECTION_NEW -> pqView::PV_SELECTION_DEFAULT
> >>>
> >>> I do not know what is the context of  pqCMBRubberBandHelper, but there
> is
> >>> now a pqRenderViewSelectionReaction::getSelectionModifier() that could
> help
> >>> you simplify this code.
> >>>
> >>> Mathieu
> >>>
> >>> Mathieu Westphal
> >>>
> >>> On Thu, Oct 8, 2015 at 6:02 PM, Bob Obara <bob.obara at kitware.com>
> wrote:
> >>>>
> >>>> Hi All,
> >>>>
> >>>> I'm trying to update CMB to use ParaView master and I'm running into
> the
> >>>> following problem:
> >>>>
> >>>>
> >>>>
> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:445:17:
> >>>> error: no type named 'pqSelectionOperator' in 'pqRenderView'
> >>>>
> >>>>   pqRenderView::pqSelectionOperator selOp = ctrl ?
> >>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;
> >>>>
> >>>>   ~~~~~~~~~~~~~~^
> >>>>
> >>>>
> >>>>
> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:445:66:
> >>>> error: no member named 'PV_SELECTION_MERGE' in 'pqRenderView'; did
> you mean
> >>>>
> >>>>       'PV_SELECTION_TOGGLE'?
> >>>>
> >>>>   pqRenderView::pqSelectionOperator selOp = ctrl ?
> >>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;
> >>>>
> >>>>
> >>>> ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
> >>>>
> >>>>
> >>>> PV_SELECTION_TOGGLE
> >>>>
> >>>>
> >>>>
> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/paraview/src/paraview/Qt/Core/pqView.h:64:5:
> >>>> note: 'PV_SELECTION_TOGGLE' declared here
> >>>>
> >>>>     PV_SELECTION_TOGGLE
> >>>>
> >>>>     ^
> >>>>
> >>>>
> >>>>
> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:445:101:
> >>>> error: no member named 'PV_SELECTION_NEW' in 'pqRenderView'
> >>>>
> >>>>   pqRenderView::pqSelectionOperator selOp = ctrl ?
> >>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;
> >>>>
> >>>>
> >>>> ~~~~~~~~~~~~~~^
> >>>>
> >>>>
> >>>>
> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:590:19:
> >>>> error: no type named 'pqSelectionOperator' in 'pqRenderView'
> >>>>
> >>>>     pqRenderView::pqSelectionOperator selOp = ctrl ?
> >>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;
> >>>>
> >>>>     ~~~~~~~~~~~~~~^
> >>>>
> >>>>
> >>>>
> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:590:68:
> >>>> error: no member named 'PV_SELECTION_MERGE' in 'pqRenderView'; did
> you mean
> >>>>
> >>>>       'PV_SELECTION_TOGGLE'?
> >>>>
> >>>>     pqRenderView::pqSelectionOperator selOp = ctrl ?
> >>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;
> >>>>
> >>>>
> >>>> ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
> >>>>
> >>>>
> >>>> PV_SELECTION_TOGGLE
> >>>>
> >>>>
> >>>>
> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/paraview/src/paraview/Qt/Core/pqView.h:64:5:
> >>>> note: 'PV_SELECTION_TOGGLE' declared here
> >>>>
> >>>>     PV_SELECTION_TOGGLE
> >>>>
> >>>>     ^
> >>>>
> >>>>
> >>>>
> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:590:103:
> >>>> error: no member named 'PV_SELECTION_NEW' in 'pqRenderView'
> >>>>
> >>>>     pqRenderView::pqSelectionOperator selOp = ctrl ?
> >>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;
> >>>>
> >>>>
> >>>> ~~~~~~~~~~~~~~^
> >>>>
> >>>>
> >>>>
> >>>>
> >>>> It seems that PV_SELECTION_MERGE and PV_SELECTION_NEW no longer
> exists -
> >>>> what is proper replacements for them?
> >>>>
> >>>> Thanks!
> >>>>
> >>>> Bob
> >>>> --
> >>>> Robert M. O'Bara, MEng.
> >>>> Assistant Director of Scientific Computing
> >>>>
> >>>> Kitware Inc.
> >>>> 28 Corporate Drive
> >>>> Suite 101
> >>>> Clifton Park, NY 12065
> >>>>
> >>>> Phone: (518) 881- 4931
> >>>
> >>>
> >>
> >>
> >>
> >> --
> >> Robert M. O'Bara, MEng.
> >> Assistant Director of Scientific Computing
> >>
> >> Kitware Inc.
> >> 28 Corporate Drive
> >> Suite 101
> >> Clifton Park, NY 12065
> >>
> >> Phone: (518) 881- 4931
> >
> >
> >
> > _______________________________________________
> > Powered by www.kitware.com
> >
> > Visit other Kitware open-source projects at
> > http://www.kitware.com/opensource/opensource.html
> >
> > Search the list archives at:
> > http://markmail.org/search/?q=Paraview-developers
> >
> > Follow this link to subscribe/unsubscribe:
> > http://public.kitware.com/mailman/listinfo/paraview-developers
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/paraview-developers/attachments/20151013/145c762e/attachment.html>