<div dir="ltr"><div><div><div>Hi<br><br></div>Well i can, but is it worth it ? this typedef has been alive for merely two months.<br></div>However i did not know about this page and will use it in the future.<br><br></div><div>Should I had new api changes in a new section ? Changes in git master ? Changes in paraview 5?<br><br></div>Mathieu<br></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature"><div dir="ltr">Mathieu Westphal<br></div></div></div>
<br><div class="gmail_quote">On Fri, Oct 9, 2015 at 5:37 PM, Utkarsh Ayachit <span dir="ltr"><<a href="mailto:utkarsh.ayachit@kitware.com" target="_blank">utkarsh.ayachit@kitware.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Mathieu,<br>
<br>
Can we document this here:<br>
<a href="https://gitlab.kitware.com/paraview/paraview/blob/master/Utilities/Doxygen/pages/MajorAPIChanges.md" rel="noreferrer" target="_blank">https://gitlab.kitware.com/paraview/paraview/blob/master/Utilities/Doxygen/pages/MajorAPIChanges.md</a>.<br>
<br>
This gets rendered by Doxygen here:<br>
<a href="http://www.paraview.org/ParaView3/Doc/Nightly/www/cxx-doc/MajorAPIChanges.html" rel="noreferrer" target="_blank">http://www.paraview.org/ParaView3/Doc/Nightly/www/cxx-doc/MajorAPIChanges.html</a><br>
<br>
On Fri, Oct 9, 2015 at 4:14 AM, Mathieu Westphal<br>
<div><div class="h5"><<a href="mailto:mathieu.westphal@kitware.com">mathieu.westphal@kitware.com</a>> wrote:<br>
> Hi<br>
><br>
> There is no more typedef, it is only an int corresponding to the enum in<br>
> pqView.h<br>
><br>
> Selection have been standardized for all kind of view, Render or Context<br>
><br>
> Mathieu Westphal<br>
><br>
> On Thu, Oct 8, 2015 at 6:55 PM, Bob Obara <<a href="mailto:bob.obara@kitware.com">bob.obara@kitware.com</a>> wrote:<br>
>><br>
>> Hi Mathieu,<br>
>><br>
>> Thanks for getting back to me on this.<br>
>><br>
>> Where is the pqSelectionOperator class now defined?  Its no longer part of<br>
>> the pqRenderView class?<br>
>><br>
>> Bob<br>
>><br>
>> On Thu, Oct 8, 2015 at 12:12 PM, Mathieu Westphal<br>
>> <<a href="mailto:mathieu.westphal@kitware.com">mathieu.westphal@kitware.com</a>> wrote:<br>
>>><br>
>>> Hi<br>
>>><br>
>>> Indeed, see pqView.h ( as hinted by your compiler error )<br>
>>><br>
>>>   enum SelectionModifier {<br>
>>>     PV_SELECTION_DEFAULT = 0,<br>
>>>     PV_SELECTION_ADDITION,<br>
>>>     PV_SELECTION_SUBTRACTION,<br>
>>>     PV_SELECTION_TOGGLE<br>
>>>   };<br>
>>><br>
>>> so<br>
>>> pqRenderView::PV_SELECTION_MERGE -> pqView::PV_SELECTION_ADDITION,<br>
>>> pqRenderView::PV_SELECTION_NEW -> pqView::PV_SELECTION_DEFAULT<br>
>>><br>
>>> I do not know what is the context of  pqCMBRubberBandHelper, but there is<br>
>>> now a pqRenderViewSelectionReaction::getSelectionModifier() that could help<br>
>>> you simplify this code.<br>
>>><br>
>>> Mathieu<br>
>>><br>
>>> Mathieu Westphal<br>
>>><br>
>>> On Thu, Oct 8, 2015 at 6:02 PM, Bob Obara <<a href="mailto:bob.obara@kitware.com">bob.obara@kitware.com</a>> wrote:<br>
>>>><br>
>>>> Hi All,<br>
>>>><br>
>>>> I'm trying to update CMB to use ParaView master and I'm running into the<br>
>>>> following problem:<br>
>>>><br>
>>>><br>
>>>> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:445:17:<br>
>>>> error: no type named 'pqSelectionOperator' in 'pqRenderView'<br>
>>>><br>
>>>>   pqRenderView::pqSelectionOperator selOp = ctrl ?<br>
>>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;<br>
>>>><br>
>>>>   ~~~~~~~~~~~~~~^<br>
>>>><br>
>>>><br>
>>>> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:445:66:<br>
>>>> error: no member named 'PV_SELECTION_MERGE' in 'pqRenderView'; did you mean<br>
>>>><br>
>>>>       'PV_SELECTION_TOGGLE'?<br>
>>>><br>
>>>>   pqRenderView::pqSelectionOperator selOp = ctrl ?<br>
>>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;<br>
>>>><br>
>>>><br>
>>>> ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~<br>
>>>><br>
>>>><br>
>>>> PV_SELECTION_TOGGLE<br>
>>>><br>
>>>><br>
>>>> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/paraview/src/paraview/Qt/Core/pqView.h:64:5:<br>
>>>> note: 'PV_SELECTION_TOGGLE' declared here<br>
>>>><br>
>>>>     PV_SELECTION_TOGGLE<br>
>>>><br>
>>>>     ^<br>
>>>><br>
>>>><br>
>>>> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:445:101:<br>
>>>> error: no member named 'PV_SELECTION_NEW' in 'pqRenderView'<br>
>>>><br>
>>>>   pqRenderView::pqSelectionOperator selOp = ctrl ?<br>
>>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;<br>
>>>><br>
>>>><br>
>>>> ~~~~~~~~~~~~~~^<br>
>>>><br>
>>>><br>
>>>> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:590:19:<br>
>>>> error: no type named 'pqSelectionOperator' in 'pqRenderView'<br>
>>>><br>
>>>>     pqRenderView::pqSelectionOperator selOp = ctrl ?<br>
>>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;<br>
>>>><br>
>>>>     ~~~~~~~~~~~~~~^<br>
>>>><br>
>>>><br>
>>>> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:590:68:<br>
>>>> error: no member named 'PV_SELECTION_MERGE' in 'pqRenderView'; did you mean<br>
>>>><br>
>>>>       'PV_SELECTION_TOGGLE'?<br>
>>>><br>
>>>>     pqRenderView::pqSelectionOperator selOp = ctrl ?<br>
>>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;<br>
>>>><br>
>>>><br>
>>>> ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~<br>
>>>><br>
>>>><br>
>>>> PV_SELECTION_TOGGLE<br>
>>>><br>
>>>><br>
>>>> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/paraview/src/paraview/Qt/Core/pqView.h:64:5:<br>
>>>> note: 'PV_SELECTION_TOGGLE' declared here<br>
>>>><br>
>>>>     PV_SELECTION_TOGGLE<br>
>>>><br>
>>>>     ^<br>
>>>><br>
>>>><br>
>>>> /Users/obara/Projects/Builds/CMBSuperBuildV4ParaViewMaster/cmb/src/cmb/Source/Applications/AppCommon/pqCMBRubberBandHelper.cxx:590:103:<br>
>>>> error: no member named 'PV_SELECTION_NEW' in 'pqRenderView'<br>
>>>><br>
>>>>     pqRenderView::pqSelectionOperator selOp = ctrl ?<br>
>>>> pqRenderView::PV_SELECTION_MERGE : pqRenderView::PV_SELECTION_NEW;<br>
>>>><br>
>>>><br>
>>>> ~~~~~~~~~~~~~~^<br>
>>>><br>
>>>><br>
>>>><br>
>>>><br>
>>>> It seems that PV_SELECTION_MERGE and PV_SELECTION_NEW no longer exists -<br>
>>>> what is proper replacements for them?<br>
>>>><br>
>>>> Thanks!<br>
>>>><br>
>>>> Bob<br>
>>>> --<br>
>>>> Robert M. O'Bara, MEng.<br>
>>>> Assistant Director of Scientific Computing<br>
>>>><br>
>>>> Kitware Inc.<br>
>>>> 28 Corporate Drive<br>
>>>> Suite 101<br>
>>>> Clifton Park, NY 12065<br>
>>>><br>
>>>> Phone: (518) 881- 4931<br>
>>><br>
>>><br>
>><br>
>><br>
>><br>
>> --<br>
>> Robert M. O'Bara, MEng.<br>
>> Assistant Director of Scientific Computing<br>
>><br>
>> Kitware Inc.<br>
>> 28 Corporate Drive<br>
>> Suite 101<br>
>> Clifton Park, NY 12065<br>
>><br>
>> Phone: (518) 881- 4931<br>
><br>
><br>
><br>
</div></div>> _______________________________________________<br>
> Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
><br>
> Visit other Kitware open-source projects at<br>
> <a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>
><br>
> Search the list archives at:<br>
> <a href="http://markmail.org/search/?q=Paraview-developers" rel="noreferrer" target="_blank">http://markmail.org/search/?q=Paraview-developers</a><br>
><br>
> Follow this link to subscribe/unsubscribe:<br>
> <a href="http://public.kitware.com/mailman/listinfo/paraview-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/paraview-developers</a><br>
><br>
</blockquote></div><br></div>