[Paraview-developers] {Int, Double}VectorProperties now require a {Int, Double}RangeDomain element?

[Biddiscombe, John A.]

I noticed that in pv 3.98 if you have an IntVector Property



     <IntVectorProperty

         name="MaskPoints"

         command="SetMaskPoints"

         number_of_elements="1"

         default_values="100" >

     </IntVectorProperty>



Nothing appears in the GUI for the numeric entry unless you add



       <IntRangeDomain name="range"/>



Which seems like the default domains were not picked up. Did something get lost, or was the patch only for double?



JB

-----Original Message-----
From: Cory Quammen [mailto:cquammen at cs.unc.edu]
Sent: 12 October 2012 15:16
To: Kyle Lutz
Cc: Biddiscombe, John A.; ParaView Developers
Subject: Re: [Paraview-developers] {Int, Double}VectorProperties now require a {Int, Double}RangeDomain element?



Kyle,



I forgot that merging is done through the gatekeeper review process.

Please ignore my request.



Cory



On Thu, Oct 11, 2012 at 11:36 PM, Cory Quammen <cquammen at cs.unc.edu<mailto:cquammen at cs.unc.edu>> wrote:

> Kyle,

>

> Could you merge it? I don't have sufficient privileges.

>

> Thanks,

> Cory

>

> On Thu, Oct 11, 2012 at 5:26 PM, Kyle Lutz <kyle.lutz at kitware.com<mailto:kyle.lutz at kitware.com>> wrote:

>> Looks good to me. I've +2'd it on gerrit.

>>

>> -kyle

>>

>> On Wed, Oct 10, 2012 at 9:39 PM, Cory Quammen <cquammen at cs.unc.edu<mailto:cquammen at cs.unc.edu>> wrote:

>>> Kyle,

>>>

>>> I've proposed a patch on gerrit

>>> (http://review.source.kitware.com/#/c/7866/) that essentially

>>> implements John's suggestion and have added you as a reviewer.

>>>

>>> Thanks,

>>> Cory

>>>

>>> On Tue, Oct 9, 2012 at 10:21 AM, Biddiscombe, John A. <biddisco at cscs.ch<mailto:biddisco at cscs.ch>> wrote:

>>>>> That is true. The new property widgets for each property are

>>>>> created according to the property's domain. We can add in some

>>>>> code to handle the case in which no domain is specified and just

>>>>> create a simple text box. Would that work for your use-case? If

>>>>> so, could you please submit a bug report and assign it to me?

>>>>

>>>>

>>>> Surely it would be much more intuitive to simply create a range domain for all int/double vector properties if one wasn't specified, you can always define

>>>>         <IntRangeDomain name="range" /> And not specify a min max.

>>>> Why not just use this as the 'default' unless the user actually overrides them. No real need to put it in the xml?

>>>>

>>>> I am aware that ints might be

>>>>         <BooleanDomain name="bool"/> But that's an override. Yes?

>>>>

>>>> JB

>>>>

>>>

>>>

>>>

>>> --

>>> Cory Quammen

>>> Research Associate

>>> Department of Computer Science

>>> The University of North Carolina at Chapel Hill

>

>

>

> --

> Cory Quammen

> Research Associate

> Department of Computer Science

> The University of North Carolina at Chapel Hill







--

Cory Quammen

Research Associate

Department of Computer Science

The University of North Carolina at Chapel Hill
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/paraview-developers/attachments/20121206/09d7a6db/attachment.htm>