[Opengeoscience-developers] Requesting for testing: geo_mapsource-2

[Aashish Chaudhary]

Sorry forgot to answer one question:

I will have a look to see if there is  a simple fix but that may not happen
until 4-4:30.

Thanks

- Aashish


On Mon, Jul 8, 2013 at 3:55 PM, Aashish Chaudhary <
aashish.chaudhary at kitware.com> wrote:

> On Mon, Jul 8, 2013 at 3:49 PM, Chris Harris <chris.harris at kitware.com>wrote:
>
>> I am just working on chemistry dashboard issue and then I will get back
>> to the review. However, I'm not sure it should go in with the zoom as it
>> is? Is it simple to fix?
>
>
> The zoom itself is not related to this (the branch didn't do anything for
> it). I am not sure if I would like to fix the zoom going past the layer as
> part of this branch primarily because
>
> 1. The branch has lots of changes and I would like to get it in
> 2. More importantly we should not allow interactions to go past the map
> layer (what does that even mean?) So I am not too much worry about handling
> that case for OSM (unless you have strong objections to it)
>
> - Aashish
>
>
>
>
>>
>> Chris
>>
>>
>> On Mon, Jul 8, 2013 at 3:46 PM, Aashish Chaudhary <
>> aashish.chaudhary at kitware.com> wrote:
>>
>>> Cool. So I guess you will get back to me on this in next hour or so?
>>> (basically +1, -1 approval ratings)?
>>>
>>> - Aashish
>>>
>>>
>>> On Mon, Jul 8, 2013 at 3:07 PM, Chris Harris <chris.harris at kitware.com>wrote:
>>>
>>>> Excellent!
>>>>
>>>>
>>>> On Mon, Jul 8, 2013 at 3:02 PM, Aashish Chaudhary <
>>>> aashish.chaudhary at kitware.com> wrote:
>>>>
>>>>> Brad increased the size to 2MB. I pushed the branch on origin as well.
>>>>>
>>>>>
>>>>> On Mon, Jul 8, 2013 at 2:26 PM, Aashish Chaudhary <
>>>>> aashish.chaudhary at kitware.com> wrote:
>>>>>
>>>>>> Currently, if you go behind the map when zoom-in (which I will fix in
>>>>>> a separate branch where you won't be able to do that), then the code may
>>>>>> break.
>>>>>>
>>>>>> Make sure that you don't go past the map layer (which could be tricky
>>>>>> sometimes as it zoomin quite fast).
>>>>>>
>>>>>> - Aashish
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Jul 8, 2013 at 2:23 PM, Chris Harris <
>>>>>> chris.harris at kitware.com> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Jul 8, 2013 at 12:01 PM, Aashish Chaudhary <
>>>>>>> aashish.chaudhary at kitware.com> wrote:
>>>>>>> > Thanks Chris. Couple of points to remember:
>>>>>>> >
>>>>>>> > 1. I kept the boundary lines (would be nice to turn it off when
>>>>>>> zoomed in
>>>>>>> > close as these are low res) for now .
>>>>>>> > 2. The zoom computation could be tweaked.
>>>>>>>
>>>>>>> Yep, It looks like you can zoom through the map and then the tiling
>>>>>>> stops working? And you end up with something like this?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> > 3. After you +1 the branch, I would like to fix the coding style
>>>>>>> for newly
>>>>>>> > added files (most of them are good)
>>>>>>> >
>>>>>>> > Thanks
>>>>>>> >
>>>>>>> >
>>>>>>> >
>>>>>>> > On Mon, Jul 8, 2013 at 11:51 AM, Chris Harris <
>>>>>>> chris.harris at kitware.com>
>>>>>>> > wrote:
>>>>>>> >>
>>>>>>> >> I will be happy to test is out for you.
>>>>>>> >>
>>>>>>> >> Chris
>>>>>>> >>
>>>>>>> >> On Mon, Jul 8, 2013 at 11:48 AM, Aashish Chaudhary
>>>>>>> >> <aashish.chaudhary at kitware.com> wrote:
>>>>>>> >> > This branch has quite a few of changes and I would like someone
>>>>>>> else
>>>>>>> >> > (Chris
>>>>>>> >> > or Dave probably) to run a quick test on it.
>>>>>>> >> >
>>>>>>> >> > Summary:
>>>>>>> >> > - Adds ability to get tiles from OSM
>>>>>>> >> > - Updated and cleaned API
>>>>>>> >> > - Basic work for projection
>>>>>>> >> > - Added code for bin based sorting
>>>>>>> >> >
>>>>>>> >> > Some of the things are not perfect (like projection when I am
>>>>>>> not
>>>>>>> >> > multiplying mecator with scaling) but that could be taken care
>>>>>>> later.
>>>>>>> >> >
>>>>>>> >> > @Dave do you have sometime this afternoon? I have a question on
>>>>>>> colop
>>>>>>> >> > map.
>>>>>>> >> >
>>>>>>> >> > --
>>>>>>> >> > | Aashish Chaudhary
>>>>>>> >> > | R&D Engineer
>>>>>>> >> > | Kitware Inc.
>>>>>>> >> > | www.kitware.com
>>>>>>> >> >
>>>>>>> >> > _______________________________________________
>>>>>>> >> > Opengeoscience-developers mailing list
>>>>>>> >> > Opengeoscience-developers at public.kitware.com
>>>>>>> >> >
>>>>>>> >> >
>>>>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers
>>>>>>> >> >
>>>>>>> >
>>>>>>> >
>>>>>>> >
>>>>>>> >
>>>>>>> > --
>>>>>>> > | Aashish Chaudhary
>>>>>>> > | R&D Engineer
>>>>>>> > | Kitware Inc.
>>>>>>> > | www.kitware.com
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> | Aashish Chaudhary
>>>>>> | R&D Engineer
>>>>>> | Kitware Inc.
>>>>>> | www.kitware.com
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> | Aashish Chaudhary
>>>>> | R&D Engineer
>>>>> | Kitware Inc.
>>>>> | www.kitware.com
>>>>>
>>>>
>>>>
>>>
>>>
>>> --
>>> | Aashish Chaudhary
>>> | R&D Engineer
>>> | Kitware Inc.
>>> | www.kitware.com
>>>
>>
>>
>
>
> --
> | Aashish Chaudhary
> | R&D Engineer
> | Kitware Inc.
> | www.kitware.com
>



-- 
| Aashish Chaudhary
| R&D Engineer
| Kitware Inc.
| www.kitware.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/opengeoscience-developers/attachments/20130708/6ddf3c50/attachment.html>